Repository navigation
feat(resolve): say when the merge driver falls back, and pin quest in the dev shell - #344
Merged
Merged
Conversation
Quest-Claim: 8f52d7e2104befa3
… the dev shell The quest merge driver fell back to `git merge-file` without a word when `quest resolve` could not run, leaving plain conflict markers in link lists. When that fallback leaves conflicts, it now prints to stderr why and which file's link lists were not auto-resolved. The dev shell now carries a quest built from a pinned, reviewed commit of this repository (a non-flake input, bumped with `nix flake update quest-pinned`), so this repository's own merges resolve link lists without running a PR head's code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
November 1, 2026 21:19
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 40 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Collaborator
Author
|
Landing edc3d9d.
(Written by Claude Opus 5.5) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
quest/m0/helpers/merge-driver.mdand deletes it, with its links from the helpers epic andrequired-heading.md.Summary
merge.quest.drivercommand can't usequest resolve, it still falls back togit merge-file. If that fallback leaves conflicts, it now prints the reason and the file (git's%P) to stderr:quest: no quest resolve on PATH, so link lists in quest/foo.md were not auto-resolved, whenquest help resolvefails (noquest, or one withoutresolve)quest: quest resolve failed, so link lists in quest/foo.md were not auto-resolved, when an installedquest resolveexits with 2 or more (for example, an older build that rejects the label options)quest.flake.nixadds aquest-pinnedinput withflake = false, pointing atgithub:moq-dev/quest.flake.lockpins it to 7a191e6, the currentmain. The dev shell builds that source'snix/package.nix, so this repository's merges resolve link lists without running a PR head's code. To bump it, runnix flake update quest-pinned.quest resolve --help, andAGENTS.mddescribe the new behavior.AGENTS.mdnotes that the dev shell'squestis the pinned build, and thatbun run --silent queststill runs the checkout.test/resolve.test.tschecks the stderr line in the missing, older, and working-questcases.Decisions
The maintainer picked the recommended option in a
/quest-completesession on 2026-11-01:maincommit, not a release. The quest's Plan asks for "a pinnedquestrelease" in the dev shell. The only release, v0.1.0 (2026-10-07), predatesquest resolve(moq-dev/quest#219, 2026-10-24), so pinning it would never resolve a link list. A reviewedmaincommit still meets the Plan's reason for a pin, since merging a PR head never runs that head's code, and it matches m0's recorded pin mechanism, "a nix flake input (any rev, built from source)".maincommit as a source-only flake input. Already implemented;nix flake update quest-pinnedbumps it.quest resolve, then pin its tag.resolve.Choices made without asking
git merge-fileresult is the same asquest resolve's, so a warning there would just be noise on every file both sides touched.flake = falseinstead of a flake input. A flake input would bring in the pinned commit's own lock. Once a pinned commit hasquest-pinnedtoo, each bump would add one more older pin to the chain. Thefollows = ""workaround prints a warning on every nix command until such a commit is pinned.healnever overwrites a configured driver, and the README already tells those clones to clearmerge.quest.driverand run any quest command. A follow-up below covers this.Checks
Merged
origin/main(clean, no rebase) at edc3d9d.just check: passes.just test: passes (762 passed, 2 skipped; 426 for each build's lifecycle) withCLAUDE_CONFIG_DIRandQUEST_WORKTREE_HOMEunset.nix develop -c quest help resolve: the pinned build providesresolve.nix flake check: passes on x86_64-linux at edc3d9d.Suggested follow-ups
healregisters the driver only when none is configured, so existing clones (this one included) keep an oldermerge.quest.drivercommand and never print the new warning.healcould recognize earlier quest-generated driver strings and replace them with the currentDRIVER, while leaving custom drivers alone.quest-pinnedis manual. It could go into the release checklist or a recurring quest, so the dev shell picks up driver fixes such as moq-dev/quest#323.Review
gpt-6.1-sol, medium effort (quest review --base origin/main).edc3d9d720e3939ecb4b52b08fe5bd0b314c36df: 0 findings.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code