Skip to content

quest: plan triage follow-ups: park failing CI, show status in the check - #363

Merged
moq-bot[bot] merged 4 commits into
mainfrom
quest-plan/fixer-followups
Nov 1, 2026
Merged

moq-bot[bot] merged 4 commits into
mainfrom
quest-plan/fixer-followups

Conversation

@kixelated

@kixelated kixelated commented Nov 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Plans two follow-ups from the maintainer's answers to moq-dev/quest#355's decisions 7 and 8 (record). Both join the quest/m0/land-fixer epic:

  • ci-park.md [S]: a queued PR whose own required GitHub CI fails is parked for the fixer with the failing checks' logs, not ejected. It requires triage's parking mechanism.
  • check-status.md [S]: the gate shows each queued PR's state (queued, waiting on checks, in a batch, parked, halted) in its required quest land check run. It only ever sets the run to queued or in progress, never completed, so auto-merge can't fire around the gate.

Decisions

  • Decision 8: ✅ park a PR with failing CI for the fixer · keep ejecting
  • Decision 7, from the maintainer: "Comment once, but should plan using the require Github check for status? If possible?" Triage posts the one comment, and check-status.md covers the check-run status. It is possible, as long as no conclusion is ever set.

Checks

  • quest check passes (81 documents), and so does just check.

Review

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

… the check

From the maintainer's answers to #355's decisions 7 and 8.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2838b8ca-dbf5-41ba-8a79-b2e3c6326c2d
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@moq-bot

moq-bot Bot commented Nov 1, 2026

Copy link
Copy Markdown

quest land removed this pull request from the queue: the batch check failed (exit 1).

     �[33m�[2m✓�[22m�[39m blames no PR for a finding the base already has�[33m 2543�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m ejects the whole failing batch with a log tail, retaining the complete log�[33m 1872�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m revalidates a moved head after checking and never merges the batch�[33m 687�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m gives the sandbox its base and a standalone shallow chain (1 queued PRs)�[33m 1390�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m gives the sandbox its base and a standalone shallow chain (3 queued PRs)�[33m 3848�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m checks the files as committed, ignoring export attributes�[33m 1267�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m starts the fixer detached in its own standalone repository, including on a base conflict�[33m 1267�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m starts the fixer on a PR that fails quest check alone, from its squash onto the base�[33m 1562�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m refuses a batch whose base changes during a check�[33m 962�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m refuses a batch whose dequeued changes during a check�[33m 1211�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m refuses a batch whose requeued changes during a check�[33m 946�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m a refused second merge ejects the remaining batch as merge_conflict and starts the fixer�[33m 3161�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m a refused second merge ejects the remaining batch as head_moved and starts the fixer�[33m 3104�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m retries a transient base modified refusal and then merges�[33m 1037�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m retries a transient mergeability pending refusal and then merges�[33m 955�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m classifies a refused merge with false�[33m 1130�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m classifies a refused merge with dirty�[33m 875�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m classifies a refused merge with squash disabled�[33m 793�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m classifies a refused merge with required check�[33m 795�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m classifies a refused merge with closed�[33m 727�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m classifies a refused merge with merged�[33m 1990�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m classifies a refused merge with pending�[33m 1460�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m classifies a refused merge with base modified�[33m 1588�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m a base push before merge 1 stops the batch without ejecting or reporting tree mismatch�[33m 2759�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m a base push before merge 2 stops the batch without ejecting or reporting tree mismatch�[33m 2820�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m a tree mismatch logs CRITICAL, keeps landed PRs, and ejects only the unmerged batch suffix�[33m 3207�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m scopes each merge token to that PR's squash, preserving it through the queue token cache�[33m 3903�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m a lost merge response never re-merges or ejects the merged PR after restart�[33m 3713�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m a restart resolves only PRs left after successful API merges�[33m 4574�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m resumes all pending ejections after a restart during a failing batch�[33m 1375�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m requests workflow write only when the selected batch touches workflows (false)�[33m 1091�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m requests workflow write only when the selected batch touches workflows (true)�[33m 1132�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m shares the repository lock across linked worktrees�[33m 383�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m fails a batch whose check outlives the timeout�[33m 1367�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m bounds a base conflict's comment however many paths conflict�[33m 7171�[2mms�[22m�[39m
   �[32m✓�[39m asynchronous land fixer �[2m(44)�[22m
     �[33m�[2m✓�[22m�[39m requeues unchanged with its reason, and hands back a second ejection in the same pick�[33m 4445�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m collects a fixed conflict after a restart, pushes and pins the new Review head�[33m 3457�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m accepts a fix whose base gained protected changes before collection�[33m 954�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m waits for GitHub to show the pushed fix before recording it�[33m 718�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m hands back handback without requeueing�[33m 520�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m hands back protected file without requeueing�[33m 608�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m hands back shell.nix without requeueing�[33m 575�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m hands back default.nix without requeueing�[33m 591�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m hands back .gitmodules without requeueing�[33m 609�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m hands back fork without requeueing�[33m 565�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m hands back crash without requeueing�[33m 489�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m hands back invalid result without requeueing�[33m 427�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m hands back symlink result without requeueing�[33m 444�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m times out a running fixer without waiting for it�[33m 478�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m survives an agent whose output outruns the launcher's reader�[33m 1458�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m requeues a PR that only shared the batch, and hands back the one that broke it�[33m 789�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m names the signal that stopped a fixer and the daemon restart behind it�[33m 487�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m waits for a fixer whose process it could not identify, and says when one stops unrecorded�[33m 491�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m passes no host credentials to wrapper or agent, including inherited Git configuration�[33m 505�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m hands back a job after losing the enable-auto-merge response�[33m 510�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m preserves a refused-push handback across a failed comment and restart�[33m 764�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m hands back deleted branch and keeps collection usable�[33m 495�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m hands back gitfile and keeps collection usable�[33m 495�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m hands back symlink and keeps collection usable�[33m 490�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m hands back corrupt objects and keeps collection usable�[33m 490�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m hands back oversized and keeps collection usable�[33m 484�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m does not import private objects through alternates�[33m 517�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m ignores an alternate store when the fixed objects are self-contained�[33m 597�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m collects an already finished job after an extended daemon outage�[33m 487�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m only deduplicates the bot's own comments�[33m 496�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m rereads the author's body immediately before recording the fix�[33m 614�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m rejects mixing individually approved protected files�[33m 320�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m rebuilds pack indexes and strictly validates packs (corrupt pack: false)�[33m 637�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m rebuilds pack indexes and strictly validates packs (corrupt pack: true)�[33m 532�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m uses the recorded agent and leaves the author's attribution alone�[33m 576�[2mms�[22m�[39m
   �[32m✓�[39m private repository reads �[2m(3)�[22m
     �[33m�[2m✓�[22m�[39m authenticates private Git reads without exposing credentials to child repositories (failed batch: false)�[33m 578�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m authenticates private Git reads without exposing credentials to child repositories (failed batch: true)�[33m 501�[2mms�[22m�[39m

�[31m⎯⎯⎯⎯⎯⎯⎯�[39m�[1m�[41m Failed Tests 1 �[49m�[22m�[31m⎯⎯⎯⎯⎯⎯⎯�[39m

�[41m�[1m FAIL �[22m�[49m test/runner.test.ts�[2m > �[22mquest runner�[2m > �[22mpauses a large conflicted continuation with a bounded question and intact checkout
�[31m�[1mError�[22m: Test timed out in 5000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".�[39m
�[36m �[2m❯�[22m <anonymous> test/runner.test.ts:�[2m1523:7�[22m�[39m
    �[90m1521|�[39m     { remove: "old.txt" },
    �[90m1522|�[39m     {
    �[90m1523|�[39m      tool: "deliver",
    �[90m   |�[39m       �[31m^�[39m
    �[90m1524|�[39m      args: { summary: "Did the thing", title: "feat: thing", body: "Bo…
    �[90m1525|�[39m     },
�[90m �[2m❯�[22m processTicksAndRejections unknown:�[2m7:39�[22m�[39m

�[31m�[2m⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯�[22m�[39m


�[2m Test Files �[22m �[1m�[31m1 failed�[39m�[22m�[2m | �[22m�[1m�[32m23 passed�[39m�[22m�[90m (24)�[39m
�[2m      Tests �[22m �[1m�[31m1 failed�[39m�[22m�[2m | �[22m�[1m�[32m733 passed�[39m�[22m�[2m | �[22m�[33m2 skipped�[39m�[90m (736)�[39m
�[2m   Start at �[22m 10:05:29
�[2m   Duration �[22m 208.15s�[2m (tests 78%, transform 19%, import 3%)�[22m

error: script "test" exited with code 1
error: recipe `_test` failed on line 33 with exit code 1
error: recipe `test` failed on line 30 with exit code 1

.

@moq-bot

moq-bot Bot commented Nov 1, 2026

Copy link
Copy Markdown

codex / Codex land fixer: Requeued unchanged: Healthy unchanged; bun run build, bun run check, bun run --silent quest check, and bun run test passed (734 passed, 2 skipped). Batch failure was a flaky 5000ms timeout in test/runner.test.ts > quest

(written by codex / Codex)

kixelated added a commit that referenced this pull request Nov 1, 2026
Under the land host's load the large-conflict continuation test took
6.4s, past vitest's 5s default, and ejected a batch of unrelated PRs
(#363, #365).

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@moq-bot
moq-bot Bot merged commit ad07b2d into main Nov 1, 2026
@moq-bot
moq-bot Bot deleted the quest-plan/fixer-followups branch November 1, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant