Repository navigation
fix(wait): resolve a starting head that a merge into the branch made - #433
Merged
Merged
Conversation
Quest-Claim: 864068858b0db1f0
`quest wait <pr> <sha>` matched the point only among pushes, so a head made by GitHub's Update branch or a merge queue's merge failed with "cannot resolve push time". Match it among every move `quest status` counts (exported `BRANCH_UPDATES`), keep reporting only real pushes as `pushed`, and report a merge into the branch after the point as its new commit instead of swallowing it in the baseline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
November 3, 2026 03:47
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Nov 3, 2026
|
quest land watch: the merge queue removed this pull request at bc41397 because it conflicts with The land fixer works on it in the background, and the watcher re-enqueues it at the back of the queue once it is fixed or judged flaky, or hands it back here with what it needs. (written by quest land watch) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes quest/m1/wait-merge-heads.md, raised by moq-dev/quest#347.
Summary
quest wait <pr> <sha>now resolves a starting head that a merge into the branch made (GitHub's Update branch, or a merge queue's merge) instead of failing withcannot resolve push time for <sha>; pass a timestamp with --since.src/cli/status.ts: exportsBRANCH_UPDATES(push, force_push, branch_creation, pr_merge, merge_queue_merge), soquest waitandquest status's enabled-head lookup share one list.src/cli/wait.ts: the point, including the default current-head point and the "not listed yet" retry, matches amongBRANCH_UPDATES. Reported pushes keep using the push-only list (PUSHES), so a merge never prints aspushedand force pushes print as before.<sha> committed ...), as a push observed while waiting is.--sincehelp: a SHA point may be any tip a push or a merge into the branch moved it to.quest/m1/README.md.Choices made without asking
committed. Before, such a merge's commit landed in the baseline and was never reported (a pre-existing gap the change exposes, since a merge can now be the point while later merges follow). The Plan only says merges must not print aspushed; reporting them as their new commit matches how pushes seen while waiting print, and keeps "a racing head move is never swallowed".PUSHESstays a local list inwait.tsbeside the sharedBRANCH_UPDATES, since onlywaitdistinguishes a push from a merge.Tests
bun run check,quest check, and the fullbun run test(940 passed, 2 skipped) pass locally. New tests intest/wait.test.tscover a SHA point made bypr_mergeandmerge_queue_merge, the default point on a merge-made head, a merge after the point reported as a commit, and that a non-moving activity (branch_deletion) never resolves the point; the first three fail on the old code.Review
mechanical fix by quest land watch:
merged main at 4c19e1125bcb4f951bfe9f48cd54a4ce657fa9a8 with the quest merge driver(head 07bf78b)quest review→ Codex,gpt-6.1-sol, medium effort🤖 Generated with Claude Code
(Written by Claude Opus 5.5)