Skip to content

quest: delete the fixer TLS quest, verified on the live host - #440

Merged
moq-bot[bot] merged 4 commits into
mainfrom
quest/m0/host-land/fixer-tls
Nov 5, 2026
Merged

moq-bot[bot] merged 4 commits into
mainfrom
quest/m0/host-land/fixer-tls

Conversation

@kixelated

@kixelated kixelated commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Finishes The fixer's container trusts public TLS certificates. The fix, kixelated/nixos#21 (stacked on kixelated/nixos#19), is deployed and verified on the live host, so this PR deletes the quest and its link.

  • Cause, confirmed before the fix: workerd's bundled BoringSSL trusts only SSL_CERT_FILE or its default /etc/ssl/cert.pem. The land image shipped only /etc/ssl/certs/ca-certificates.crt plus NIX_SSL_CERT_FILE, so every outbound TLS connection failed with the error from the moq-dev/quest#331 handback.
  • Fix: link /etc/ssl/cert.pem to the bundle in the image. Check containers boot the same image, so they get the same fix, and the quest-land VM test asserts the file.
  • Deployed 2026-11-04 by the maintainer's coordinator: kixelated/nixos#20 and fix(skills): spawn agents in their own worktree and re-check readiness before claiming #21 are live on the land host nixos (generation 80, deploy/quest-land at b5d46f3). Every quest-land-root image in the deployed repository registry has /etc/ssl/cert.pem -> certs/ca-certificates.crt.
  • The quest's host-land epic now has no children, so its README takes a size, [XS].

Live check

No fixer job had run since the deploy at 05:42 UTC, so the check was run by hand on the host (read-only: a scratch copy under /var/tmp, removed afterwards; no config change). The deployed moq-dev/quest fixer image (/nix/store/08rswf0a…-quest-land-root) was copied and booted with systemd-nspawn, using the launcher's binds (/nix/store read-only, the nix daemon socket, /work, --resolv-conf=off), the deployed fix command's environment, and uid 1000 under nix develop, as the fixer does. It ran on the host network rather than a fixer slot's namespace, so a live fixer job could not collide with it. SSL_CERT_FILE was unset both outside and inside the devShell, so trust came only from the image.

  • cd cloudflare && bun install --frozen-lockfile && bun run test on main (ea82cac) passed: 21 files, 538 tests, and the seeded --check, with no TLS error.
  • Main's Worker tests no longer make outbound TLS calls (dev/serve.ts routes every outbound request to the fake), so the same suite also passes with cert.pem removed. To check the failing path directly, a Miniflare worker in the same container fetched https://example.com/:
    • deployed image: status 200
    • with /etc/ssl/cert.pem removed: kj/compat/tls.c++:269: failed: TLS peer's certificate is not trusted; reason = unable to get local issuer certificate, the handback's error

Choices made without asking

  • Fixed it with the default trust file rather than exporting SSL_CERT_FILE: it needs no environment, so it survives Quest's agent environment filter and nix develop.
  • Sized the now-childless host gate epic [XS]. Its own remaining work is keeping the frozen gate serving until the repositories follow, and retire owns retiring it. The merge-commit exception it records has already landed (moq-dev/quest#467).

Validation

  • quest check --base origin/main passes (74 documents).
  • The live check above.

Review

Skipped: a quest-file deletion plus a size tag, with no code. The code change, kixelated/nixos#21, had a Codex review (gpt-6.1-sol, medium) on e95df2d with no findings.

Follow-ups

None.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5 with low effort)

kixelated and others added 2 commits November 2, 2026 20:40
…eploy

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title The fixer's container trusts public TLS certificates quest: fix the fixer's TLS trust (kixelated/nixos#21) Nov 3, 2026
kixelated and others added 2 commits November 4, 2026 21:49
kixelated/nixos#21 is deployed (generation 80). In the deployed quest
fixer image, workerd's outbound fetch returns 200 and the Worker tests
pass; removing /etc/ssl/cert.pem reproduces the handback's TLS error.
The host-land epic has no children left, so its README takes a size.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title quest: fix the fixer's TLS trust (kixelated/nixos#21) quest: delete the fixer TLS quest, verified on the live host Nov 5, 2026
@kixelated
kixelated marked this pull request as ready for review November 5, 2026 05:50

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — verified the full diff against the quest conventions and the PR's own claims: the deletion leaves no dangling references, the size tag follows the doc rules, and quest check passes.

  • Deleted the finished fixer-tls quest — removes quest/m0/host-land/fixer-tls.md entirely, along with its ## Required entry in the epic README.
  • Sized the now-childless epic — retitles quest/m0/host-land/README.md to # [XS] Merge through a host gate until the merge queue replaces it, which is what turns the childless epic into a leaf quest (src/core/doc.ts:129-136 documents that a README takes a size exactly when it stops having children).

Verification that backs this:

  • quest check --base origin/main passes here: 74 documents ok.
  • grep for fixer-tls across the checkout returns nothing — no leftover links or citations.
  • The [XS] retitle is the convention-correct move for a README whose last child is gone, and the file deletion plus link removal is the documented way a finished quest leaves the tree (README.md's finishing-a-quest section).

The fix itself lives in the private kixelated/nixos repo and can't be re-checked from this repo, but the PR body records the deployment (host, generation, deploy/quest-land commit) and the live check at enough specificity to accept on the author's record. No findings.

Pullfrog  | View workflow run | Using glm-5.3-flash | 𝕏

@coderabbitai

coderabbitai Bot commented Nov 5, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The host-land README title now marks the host-gate merge plan as superseded. The README’s “Required” section and Fixer TLS link were removed. The Fixer TLS planning document was deleted.

Merge Risk: Minimal · up to 855e7

This removes the TLS quest and resizes its parent epic. No merge-blocking impact is evident.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title clearly identifies the main change: deleting the fixer TLS quest. It also states that the change was verified on the live host.
Description check Passed The description directly explains the quest deletion, the deployed TLS fix, live verification, and validation results. It is fully related to the changeset.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c8f24355-c806-4780-a54f-adfef0873630
Commits

Reviewing files that changed from the base of the PR and between ea82cac and 855e7b1.

Files selected for processing: 2

  • quest/m0/host-land/README.md
  • quest/m0/host-land/fixer-tls.md
Files with no reviewable changes: 1

  • quest/m0/host-land/fixer-tls.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@kixelated
kixelated added this pull request to the merge queue Nov 5, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 5, 2026
@moq-bot

moq-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown

quest land watch: the merge queue removed this pull request at 855e7b1 because its merge_group build failed (failed_checks).

The land fixer works on it in the background, and the watcher re-enqueues it at the back of the queue once it is fixed or judged flaky, or hands it back here with what it needs.

Queue / Queue build / Build (job) failure at step Test:

…alse)�[33m 434�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m authenticates private Git reads without exposing credentials to child repositories (failed batch: true)�[33m 419�[2mms�[22m�[39m
   �[32m✓�[39m quest land apply �[2m(9)�[22m
     �[33m�[2m✓�[22m�[39m rebuilds the fixer's commit from a refused workflow push, for the maintainer to push�[33m 595�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m hands back a fixer's resolution of a protected conflict as a ready commit, never pushing it�[33m 517�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m hands back a protected fix that merges no base as a commit on the PR head�[33m 532�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m refuses a PR whose head moved since the handback�[33m 559�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m trusts only an App's resolution�[33m 550�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m refuses a resolution whose tree the rebuild does not reach�[33m 572�[2mms�[22m�[39m
    �[90m434|�[39m );
    �[90m435|�[39m
    �[90m436|�[39m fakes("a reviewer's usage limit exits 3 with its reset, and records no…
    �[90m   |�[39m �[31m^�[39m
    �[90m437|�[39m  // Codex prints its reset in the local time zone, which this process …
    �[90m438|�[39m  const codex = new Date(2026, 10, 5, 15, 15).toISOString().replace(".0…

�[31m�[2m⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯�[22m�[39m


�[2m Test Files �[22m �[1m�[31m1 failed�[39m�[22m�[2m | �[22m�[1m�[32m28 passed�[39m�[22m�[90m (29)�[39m
�[2m      Tests �[22m �[1m�[31m1 failed�[39m�[22m�[2m | �[22m�[1m�[32m1080 passed�[39m�[22m�[2m | �[22m�[33m5 skipped�[39m�[90m (1086)�[39m
�[2m   Start at �[22m 22:14:52
�[2m   Duration �[22m 216.31s�[2m (tests 94%, transform 5%, import 1%)�[22m


##[error]Error: Test timed out in 5000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
 ❯ test/review.test.ts:436:1


error: script "test" exited with code 1
error: recipe `_test` failed on line 33 with exit code 1
error: recipe `test` failed on line 30 with exit code 1
##[error]Process completed with exit code 1.
Post job cleanup.
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git version
git version 2.55.0
Temporarily overriding HOME='/var/cache/github-runner-work/_temp/3a969603-eb23-4ef2-9e71-b80aa8e8f16b' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git config --global --add safe.directory /var/cache/github-runner-work/quest/quest
Removing SSH command configuration
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git config --local --name-only --get-regexp core\.sshCommand
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git config --local --name-only --get-regexp ^includeIf\.gitdir:
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
Post job cleanup.
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git version
git version 2.55.0
Temporarily overriding HOME='/var/cache/github-runner-work/_temp/3d06b9a1-0fbd-48de-a43e-fc8c768daa42' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git config --global --add safe.directory /var/cache/github-runner-work/quest/quest
Removing SSH command configuration
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git config --local --name-only --get-regexp core\.sshCommand
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git config --local --name-only --get-regexp ^includeIf\.gitdir:
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
A job completed hook has been configured by the self-hosted runner administrator
##[group]Run '/nix/store/gx2v6q84b0w43bafm0whkdx93qyxbpps-ci-cache-gc.sh/bin/ci-cache-gc.sh'
shell: /nix/store/1mv3qz005gkbalxfghk4y3s8ayv4d2dl-bash-interactive-5.3p15/bin/bash --noprofile --norc -e -o pipefail {0}
##[endgroup]
evicted 0 objects and 0 action results (4.2 KiB logical); 49.9 GiB logical remain
dropped 1 stale checkout records
dropped 1 session event streams
Cleaning up orphan processes

Queue / Queue (job) failure at step Require the build to pass:

Current runner version: '2.338.2'
##[group]Runner Image Provisioner
Hosted Compute Agent
Version: 20261021.618
Commit: 21505ad2541d5be6135ed84fc33697146cf75b8e
Build Date: 2026-10-21T00:45:21Z
Worker ID: {33526410-88e0-412c-8037-1977ecdf9b68}
Region: eastus
Cloud: Azure
##[endgroup]
##[group]Operating System
Ubuntu
24.04.5
LTS
##[endgroup]
##[group]Runner Image
Image: ubuntu-24.04
Version: 20261025.353.1
Included Software: https://github.com/actions/runner-images/blob/ubuntu24/20261025.353/images/ubuntu/Ubuntu2404-Readme.md
Image Release: https://github.com/actions/runner-images/releases/tag/ubuntu24%2F20261025.353
##[endgroup]
##[group]GITHUB_TOKEN Permissions
Contents: read
Metadata: read
PullRequests: read
##[endgroup]
Secret source: Actions
Cache mode: write
Prepare workflow directory
Prepare all required actions
Complete job name: Queue
##[group]Run [[ "$RESULT" == success ]] || { echo "::error::the queue build ended $RESULT" >&2; exit 1; }
�[36;1m[[ "$RESULT" == success ]] || { echo "::error::the queue build ended $RESULT" >&2; exit 1; }�[0m
shell: /usr/bin/bash -e {0}
env:
  RESULT: failure
##[endgroup]
##[error]the queue build ended failure
##[error]Process completed with exit code 1.
Cleaning up orphan processes

(written by quest land watch)

@moq-bot
moq-bot Bot added this pull request to the merge queue Nov 5, 2026
@moq-bot

moq-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown

codex / Codex land fixer note:

The queue failure was a 5000ms timeout in test/review.test.ts > a reviewer's usage limit exits 3 with its reset, and records no round. This PR changes only quest Markdown and does not alter the test or its implementation. It merges cleanly with current base. The merged tree passed all 1081 CLI tests with the default timeout, including the failing test, plus TypeScript, formatting, quest validation, bundled and compiled builds, and lifecycle checks. No branch changes were needed. Additional Worker validation encountered separate 5000ms timeouts in test/github.test.ts > signed GitHub webhooks > acknowledges and drops every delivery from an owner off the allowlist and then test/projects.test.ts > enrolled project observations > withholds candidates after push {"ref":"refs/heads/quest/first","created":true} until a refresh rereads occupancy. All 538 Worker tests passed with a command-line timeout of 15000ms, and the seeded check passed. These timing failures merit follow-up; no test settings or source files were changed.

(written by codex / Codex)

@moq-bot

moq-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown

quest land watch: re-enqueued this pull request at 855e7b1, at the back of the merge queue, unchanged, since the land fixer judged the failure flaky: bun run test: test/review.test.ts > a reviewer's usage limit exits 3 with its reset, and records no round.

(written by quest land watch)

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 5, 2026
@moq-bot

moq-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown

quest land watch: the merge queue removed this pull request at 855e7b1 because its merge_group build failed (failed_checks).

The land fixer works on it in the background, and the watcher re-enqueues it at the back of the queue once it is fixed or judged flaky, or hands it back here with what it needs.

Queue / Queue build / Build (job) failure at step Test:

…tected conflict as a ready commit, never pushing it�[33m 648�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m hands back a protected fix that merges no base as a commit on the PR head�[33m 773�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m refuses a PR whose head moved since the handback�[33m 696�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m trusts only an App's resolution�[33m 719�[2mms�[22m�[39m
     �[33m�[2m✓�[22m�[39m refuses a resolution whose tree the rebuild does not reach�[33m 684�[2mms�[22m�[39m

�[31m⎯⎯⎯⎯⎯⎯⎯�[39m�[1m�[41m Failed Tests 1 �[49m�[22m�[31m⎯⎯⎯⎯⎯⎯⎯�[39m

�[41m�[1m FAIL �[22m�[49m test/review.test.ts�[2m > �[22ma reviewer's usage limit exits 3 with its reset, and records no round
�[31m�[1mError�[22m: Test timed out in 5000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".�[39m
�[36m �[2m❯�[22m test/review.test.ts:�[2m436:1�[22m�[39m
    �[90m434|�[39m );
    �[90m435|�[39m
    �[90m436|�[39m fakes("a reviewer's usage limit exits 3 with its reset, and records no…
    �[90m   |�[39m �[31m^�[39m
    �[90m437|�[39m  // Codex prints its reset in the local time zone, which this process …
    �[90m438|�[39m  const codex = new Date(2026, 10, 5, 15, 15).toISOString().replace(".0…

�[31m�[2m⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯�[22m�[39m


�[2m Test Files �[22m �[1m�[31m1 failed�[39m�[22m�[2m | �[22m�[1m�[32m28 passed�[39m�[22m�[90m (29)�[39m
�[2m      Tests �[22m �[1m�[31m1 failed�[39m�[22m�[2m | �[22m�[1m�[32m1080 passed�[39m�[22m�[2m | �[22m�[33m5 skipped�[39m�[90m (1086)�[39m
�[2m   Start at �[22m 22:34:06
�[2m   Duration �[22m 111.37s�[2m (tests 90%, transform 5%, import 5%)�[22m


##[error]Error: Test timed out in 5000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
 ❯ test/review.test.ts:436:1


error: script "test" exited with code 1
error: recipe `_test` failed on line 33 with exit code 1
error: recipe `test` failed on line 30 with exit code 1
##[error]Process completed with exit code 1.
Post job cleanup.
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git version
git version 2.55.0
Temporarily overriding HOME='/var/cache/github-runner-work/_temp/b2f6e166-1738-48e7-94a9-d37e477e7a3d' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git config --global --add safe.directory /var/cache/github-runner-work/quest/quest
Removing SSH command configuration
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git config --local --name-only --get-regexp core\.sshCommand
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git config --local --name-only --get-regexp ^includeIf\.gitdir:
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
Post job cleanup.
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git version
git version 2.55.0
Temporarily overriding HOME='/var/cache/github-runner-work/_temp/4ab22784-4d55-416b-871d-ddc05fd812a5' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git config --global --add safe.directory /var/cache/github-runner-work/quest/quest
Removing SSH command configuration
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git config --local --name-only --get-regexp core\.sshCommand
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git config --local --name-only --get-regexp ^includeIf\.gitdir:
[command]/nix/store/lg46w7hrjx7kylsh6645c9l975i8h43b-git-2.55.0/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
A job completed hook has been configured by the self-hosted runner administrator
##[group]Run '/nix/store/gx2v6q84b0w43bafm0whkdx93qyxbpps-ci-cache-gc.sh/bin/ci-cache-gc.sh'
shell: /nix/store/1mv3qz005gkbalxfghk4y3s8ayv4d2dl-bash-interactive-5.3p15/bin/bash --noprofile --norc -e -o pipefail {0}
##[endgroup]
evicted 604 objects and 103 action results (179.3 MiB logical); 50.0 GiB logical remain
dropped 1 stale checkout records
dropped 3 session event streams
Cleaning up orphan processes

Queue / Queue (job) failure at step Require the build to pass:

Current runner version: '2.338.2'
##[group]Runner Image Provisioner
Hosted Compute Agent
Version: 20261021.618
Commit: 21505ad2541d5be6135ed84fc33697146cf75b8e
Build Date: 2026-10-21T00:45:21Z
Worker ID: {9a37ccc8-0339-41a0-b0f6-29e16cc229cd}
Region: westus3
Cloud: Azure
##[endgroup]
##[group]Operating System
Ubuntu
24.04.5
LTS
##[endgroup]
##[group]Runner Image
Image: ubuntu-24.04
Version: 20261025.353.1
Included Software: https://github.com/actions/runner-images/blob/ubuntu24/20261025.353/images/ubuntu/Ubuntu2404-Readme.md
Image Release: https://github.com/actions/runner-images/releases/tag/ubuntu24%2F20261025.353
##[endgroup]
##[group]GITHUB_TOKEN Permissions
Contents: read
Metadata: read
PullRequests: read
##[endgroup]
Secret source: Actions
Cache mode: write
Prepare workflow directory
Prepare all required actions
Complete job name: Queue
##[group]Run [[ "$RESULT" == success ]] || { echo "::error::the queue build ended $RESULT" >&2; exit 1; }
�[36;1m[[ "$RESULT" == success ]] || { echo "::error::the queue build ended $RESULT" >&2; exit 1; }�[0m
shell: /usr/bin/bash -e {0}
env:
  RESULT: failure
##[endgroup]
##[error]the queue build ended failure
##[error]Process completed with exit code 1.
Cleaning up orphan processes

(written by quest land watch)

@moq-bot
moq-bot Bot added this pull request to the merge queue Nov 5, 2026
@moq-bot

moq-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown

codex / Codex land fixer note:

The CI failure was a 5000ms timeout in test/review.test.ts > a reviewer's usage limit exits 3 with its reset, and records no round. This PR changes only quest documentation and does not change that test or its implementation. Tested the PR merged with the current base without changing its branch. The exact test passed alone in 2.14 seconds, all 55 review tests passed, and the full suite passed with bun run test -- --maxWorkers=1 --no-file-parallelism --reporter=verbose (1081 passed, 5 skipped). Build, TypeScript, formatting, quest validation, and CLI lifecycle checks passed. The default full-suite run stalled locally and was stopped; the serial rerun passed. Please track the timeout and full-suite stall as test reliability issues.

(written by codex / Codex)

@moq-bot

moq-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown

quest land watch: re-enqueued this pull request at 855e7b1, at the back of the merge queue, unchanged, since the land fixer judged the failure flaky: bun run test: test/review.test.ts > a reviewer's usage limit exits 3 with its reset, and records no round.

(written by quest land watch)

Merged via the queue into main with commit 388308c Nov 5, 2026
13 checks passed
@moq-bot
moq-bot Bot deleted the quest/m0/host-land/fixer-tls branch November 5, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant