Repository navigation
fix(ci): never cancel a pull request's Queue check - #450
Merged
Merged
Conversation
The workflow-level concurrency group cancelled a pull request's run when a second event for the PR arrived within seconds (a push, then a body edit). Its `Queue` job, which waits on `build` before it skips, then reported cancelled and failed the required check. Even without cancel-in-progress, a group cancels a pending run, so drop the group: merge groups each have their own ref, and a repeated dispatch only reports the same skipped context. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 21 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
moq-dev/quest#439 made the required
Queuejob report the reusable build's result:needs: buildwithif: always() && github.event_name == 'merge_group'. On a pull request that job now waits forbuildto skip before it skips itself. The workflow-levelconcurrencygroup (cancel-in-progress: true) cancels a PR's run when a second event for the same PR arrives within seconds, such assynchronizefrom a push followed byeditedfrom a body edit. The cancelled run'sQueuecheck then reports cancelled, which fails the required check and blocks enqueueing.Seen on moq-dev/quest#445, head
adb28aa6: run 41683755363 hadQueuecancelled whileQueue buildandReport Queueskipped, next to run 41683758122, which skipped normally. Both were created in the same second.Approach
Drop the workflow's
concurrencygroup and say why in a comment:Queuecheck always ends skipped.Queuestill runs underalways()and fails when the build fails or is cancelled, so a skipped context can't pass the group.Alternatives
cancel-in-progress: ${{ github.event_name != 'pull_request' }}: rejected. A group without cancel-in-progress still cancels a pending run when a newer one queues (GitHub docs on concurrency), so three quick events would still cancel the middle run'sQueue.Queueskip immediately off merge groups: not possible while it keepsneeds: build, since a job waits for its needs before it evaluatesif.always()is what keeps it running when the build is cancelled (status check functions). Droppingneedswould lose the build's result.Impact
Related
Review
quest review --base origin/main), gpt-6.1-sol, medium effort373fd2fe597d8a2546dd39054da21fc0a0a00f09Follow-ups
(written by Claude Opus 5.5)
🤖 Generated with Claude Code