Repository navigation
quest: plan keeping .worktrees/ out of git status - #486
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 51 seconds. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — the full branch against base main (4b3faf1):
- New quest plan —
quest/m0/user-dev-shell/worktrees-exclude.mdplansquest worktreeappending/.worktrees/to the clone's$GIT_COMMON_DIR/info/excludeunless something already ignores it, with the recorded decisions and a test matrix. - Epic README row —
quest/m0/user-dev-shell/README.md's## Requiredlist gains the link to the new quest, in the same format as its siblings.
Facts in the plan checked out against the code and git itself: ignored() does use git check-ignore (src/cli/worktree.ts:152); nothing in src/ writes info/exclude; both quest worktree create (src/cli/main.ts:753) and the Claude hook (src/cli/worktree-hook.ts:203) go through Worktrees.create, which places every checkout at <toplevel>/.worktrees/<name> (src/cli/worktree.ts:614). The trailing-slash guidance reproduces exactly: in a fresh repository with /.worktrees/ in info/exclude, git check-ignore .worktrees exits 1 until the directory exists, while .worktrees/ matches in both states. bun run --silent quest check passes with 70 documents ok.
glm-5.3-flash | 𝕏

Plans
quest/m0/user-dev-shell/worktrees-exclude.md, the follow-up moq-dev/quest#466 suggested. With Quest's worktree hooks now opted into at user level, they run in every repository, and one that doesn't ignore.worktrees/shows?? .worktrees/ingit status.Changes
[S] .worktrees/ stays out of git statusin the m0 user-dev-shell epic.quest worktreeadds/.worktrees/to the clone's$GIT_COMMON_DIR/info/excludeunless something already ignores it.Decisions
Settled with the maintainer in /quest-complete on 2026-11-04:
quest worktreeReview
Codex
gpt-6.1-solat xhigh effort,quest review --base origin/main, round 1 on head 914a4f7: no findings.That head merges
origin/maininto the earlier reviewed head 804ae33 (Codex, no findings) to resolve the conflict from moq-dev/quest#466 deletinginit-hooks.mdbeside this quest's Required row; the quest merge driver resolved it andquest check --fixchanged nothing. The diff's context lines changed, so it was reviewed again rather than exempted. The plan's facts still hold on the merged code:ignored()runsgit check-ignore(src/cli/worktree.ts:131), every checkout lands at<repository>/.worktrees/<name>(src/cli/worktree.ts:584), and nothing insrc/writesinfo/exclude.Head 23a2ff1 is a conflict-free merge of newer
origin/main;git diff origin/main...HEADprints the same as for 914a4f7, so that review covers it.just checkpasses on it. No automated review findings are posted on 804ae33 (pullfrog: no new issues; CodeRabbit rate-limited).🤖 Generated with Claude Code
(Written by Claude Opus 5.5)