Skip to content

quest: delete the fixer broken pipe quest, fixed on the host - #616

Merged
kixelated merged 4 commits into
mainfrom
quest/m0/queue-watcher/fixer-broken-pipe
Nov 10, 2026
Merged

kixelated merged 4 commits into
mainfrom
quest/m0/queue-watcher/fixer-broken-pipe

Conversation

@kixelated

@kixelated kixelated commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Deletes quest/m0/queue-watcher/fixer-broken-pipe.md and its one link, in quest/m0/test-cpu-timeout.md, with quest rm. Git history keeps the file.

Summary

The fixer's quest land check: [Errno 32] Broken pipe handbacks were not a Quest bug. The maintainer's host ran a fixer launcher that refused quest 0.2.0's owner-repo@main state paths, and the host's fixer wrapper then printed the broken pipe instead of the refusal. The host now runs a system with the fix, and the fixer gives real verdicts again, so the quest is done.

No code changes. Public API: none. Wire: none.

Decisions

The maintainer chose to land the evidence and delete the quest once the host switch was verified. Both happened:

  • The host was switched to kixelated/nixos fef1acc, which contains kixelated/nixos#46, at 2026-11-10T22:43Z.
  • No fixer run since then has logged failure log must be (0 of 5).
  • The first real verdict came at 23:06Z on moq-dev/moq.pro#3823: a merge-conflict handback naming the actual cause, not the broken pipe.

Evidence for the cause, read-only on the host:

  • The wrapper is scripts/quest-land-check.py in kixelated/nixos (client side). From 2026-11-10T00:33Z, a minute after a host switch, the launcher refused every request with failure log must be a .log path below the repository state directory, since its path pattern ([A-Za-z0-9_./-]+) lacked @. The wrapper, still uploading, hit EPIPE and printed that instead of the refusal; Quest then correctly reported the wrapper's exit 1 as fixer crashed (exit 1).
  • journalctl -u 'quest-land-fixer@*': 53 of the 60 fixer runs from 00:00Z to the fix were refused this way, every one from 00:33Z on. Each refused job's log in /var/lib/quest-land-moq-pro/moq-dev-moq.pro@main/fix-job-*.json.log is exactly the 41-byte broken-pipe line.
  • kixelated/nixos#46 (a1b33e1, merged 19:12Z) fixed both the @ pattern and the lost refusal frame, with a protocol test that closes the upload mid-stream.

Drops it hid, with their real causes from the batch logs:

  • moq-dev/moq#8406: a failed merge_group build from a dead quest link. moq-dev/moq#8429: a merge conflict.
  • moq-dev/moq.pro#3816, handed back 20:18Z: its batch failed dev/check-instructions.sh, as .claude/skills/quest-review/SKILL.md is 287 bytes against a 280-byte budget. It landed after a requeue.
  • moq-dev/moq.pro#3822 and moq-dev/moq.pro#3820, 22:01Z: two TS2362 errors at api/test/account-free-tier.test.ts:885-886, a file moq-dev/moq.pro#3822 changes.
  • moq-dev/moq.pro#3820 again, 22:13Z: dev/check-migrations.py lists live deploy tags from origin, a remote the gate's checkout lacks.

Choices made without asking

  • Named moq-dev/moq.pro and kixelated/nixos as plain text, not links, since this repository is public and those are private.

Suggested follow-ups

  • Quest: when the fixer wrapper itself crashes, the handback carries only the wrapper's log, hiding the gate failure that parked the PR. Quoting the gate's failure log in that handback would have shown every cause above without host access. Recommend planning it here.
  • moq-dev/moq.pro: dev/check-migrations.py fails in the gate's checkout, which has no origin remote. Recommend planning it in moq-dev/moq.pro, not here.

Caused by

  • kixelated/nixos (private): the fixer launcher's path pattern predates quest 0.2.0's @ state directories; no moq-dev/quest PR caused it.

Validation

  • quest check: 28 documents ok.
  • just check and just test in the dev shell: both pass.

Review

Skipped as trivial: a quest deletion by quest rm with no code, on head b2620eb. That head merges main, whose #617 had added a note to the deleted quest (the batch logs held the real failures; a fixed fixer should still name them); the deletion stands, and that point is planned in #618.

Models

Size: XS
Implementer: Claude Code, Opus 5.5, high effort

(Written by Opus 5.5 with high)

@pullfrog

pullfrog Bot commented Nov 10, 2026

Copy link
Copy Markdown

Pullfrog  | Review this ➔

The [Errno 32] came from the host's fixer wrapper, whose launcher refused
quest 0.2.0's @ state paths. Record the moq.pro drops and their real
causes, and wait on the host switch that deploys the fix.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title The land fixer survives a closed pipe quest: trace the fixer's broken pipe to the host launcher Nov 10, 2026
The maintainer's host now runs a system with the launcher fix: no fixer run
since the switch was refused, and the next drop got a real verdict. The
evidence moves to the PR body.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title quest: trace the fixer's broken pipe to the host launcher quest: delete the fixer broken pipe quest, fixed on the host Nov 10, 2026
@kixelated
kixelated marked this pull request as ready for review November 10, 2026 23:21
@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 34 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3eae7cce-f8e9-4e28-84c2-8e4e25c727ff
Commits

Reviewing files that changed from the base of the PR and between 1de380b and b2620eb.

Files selected for processing: 2

  • quest/m0/queue-watcher/fixer-broken-pipe.md
  • quest/m0/test-cpu-timeout.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head: 6b8b497

No actionable findings in this documentation-only deletion. It removes the broken-pipe quest and its related link together, consistent with the reported fix being in the host launcher rather than Quest. The referenced host-side change is merged and includes regression coverage for the reported path/refusal handling.

Verification limits: GitHub-only static review of this diff, the remaining related quest, and the referenced fix. No tests or quest check run. I did not independently verify the live host switch, journal counts, or subsequent fixer verdicts, so the deployment evidence remains the PR author's report.

(Written by review (OpenAI))

@kixelated
kixelated added this pull request to the merge queue Nov 10, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 10, 2026
@moq-bot

moq-bot Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

quest land watch: the merge queue removed this pull request at 6b8b497 because it conflicts with main (merge_conflict).

The land fixer works on it in the background, and the watcher re-enqueues it at the back of the queue once it is fixed or judged flaky, or hands it back here with what it needs.

(written by quest land watch)

…r/fixer-broken-pipe

# Conflicts:
#	quest/m0/queue-watcher/fixer-broken-pipe.md
@kixelated
kixelated added this pull request to the merge queue Nov 10, 2026
Merged via the queue into main with commit c8d263e Nov 10, 2026
9 checks passed
@kixelated
kixelated deleted the quest/m0/queue-watcher/fixer-broken-pipe branch November 10, 2026 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant