Skip to content

fix(release): return rind to 0.3.2 and set four adapter patch versions by hand - #548

Merged
kixelated merged 7 commits into
mainfrom
fix/release-0.3.3
Nov 10, 2026
Merged

kixelated merged 7 commits into
mainfrom
fix/release-0.3.3

Conversation

@kixelated

@kixelated kixelated commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Returns rind to its published 0.3.2 so release-plz proposes 0.4.0 from the ! commits on main, and sets four adapters to their next patch version by hand.

Why

main holds two breaking changes to rind: the typed CbcIv (moq-dev/rind#530) and agreement keys that keep their public key (moq-dev/rind#529). Both merged while rind/Cargo.toml was hand-set to an unpublished 0.3.3. release-plz keeps a version that differs from the published one, so release PR moq-dev/rind#511 proposed publishing both breaks as 0.3.3.

With the manifest back at 0.3.2, release-plz computes the next version itself. Verified in release-plz's next_version crate: a breaking commit bumps the minor on 0.x unless breaking_always_increment_major is set, and .release-plz.toml does not set it. #511 proposing rind-rustls 0.24.0 etc. for ! adapter commits shows the same rule in practice.

#511 also proposed rind-rustls 0.24.0, rind-rcgen 0.15.0, rind-ring 0.18.0, and rind-str0m 0.26.0, which sh/adapter-versions.sh refuses: an adapter's version begins with its upstream's breaking part.

Changes

Decisions

Maintainer, 2026-11-10 (/quest-complete):

  • ✅ Return rind to the published 0.3.2 and let release-plz propose 0.4.0 (rejected: hand-set 0.4.0, which this PR first did). Every workspace rind requirement matches; the README's 0.4 snippet change is undone.
  • ✅ Adapters stay hand-set to their next patch: rind-rustls 0.23.4, rind-rcgen 0.14.4, rind-ring 0.17.4, rind-str0m 0.25.3, and any other adapter release-plz would bump to a breaking version (none found).

Earlier, 2026-11-09 (moq-dev/rind#546): hold the release until the CPU-check removal, 0.4's third breaking change, lands. Still in force.

After this merges

Public API and wire

None. The pending breaks publish as rind 0.4.0 instead of 0.3.3. Wire: none.

Checks

just check passes, including sh/adapter-versions.sh.

Models

Size: S
Implementer: Claude Code, claude-fable-5-2, high effort
Implementer: Claude Code, claude-opus-5-5 (iterate, S)

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Review

Rewritten by quest review after each round.

  • Reviewer: Codex, gpt-6.1-sol, medium effort
  • Session: 01a1c69c-719b-7de0-91b4-e02e23d398d1, round 1
  • Head: 301b408
  • Base: origin/main at 0323ec7
  • Score: 9/10, The scoped diff consistently updates manifest and lockfile versions in line with the recorded release decision without changing cryptographic code; code inspection found no actionable defects, and builds and tests were intentionally not run.
  • Findings: none

kixelated and others added 5 commits November 9, 2026 17:22
release-plz proposed rind-rustls 0.24.0 and rind-rcgen 0.15.0, which the
adapter version rule refuses: an adapter's version begins with its
upstream's breaking part. Both changes restore upstream's API, so each is
a patch release.

Co-Authored-By: Claude <noreply@anthropic.com>
… by hand

main holds two breaking rind changes at a hand-set 0.3.3, which the release
PR would publish as a patch. Setting 0.4.0 makes them, and any later one,
publish under the right version. The adapters require rind 0.4.0 and keep
their upstream's version prefix.

Co-Authored-By: Claude <noreply@anthropic.com>
@kixelated kixelated changed the title fix(release): revert the typed CbcIv until rind 0.4, and set two adapter versions fix(release): set rind 0.4.0 and four adapter patch versions by hand Nov 10, 2026
@kixelated kixelated changed the title fix(release): set rind 0.4.0 and four adapter patch versions by hand fix(release): return rind to 0.3.2 and set four adapter patch versions by hand Nov 10, 2026
@kixelated
kixelated marked this pull request as ready for review November 10, 2026 17:59
@coderabbitai

coderabbitai Bot commented Nov 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 36 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 47f4ae9b-00c5-48c1-88a2-1ac265e433e3
Commits

Reviewing files that changed from the base of the PR and between 53fcf3a and 301b408.

Files ignored due to path filters: 1

  • Cargo.lock is excluded by !**/*.lock
Files selected for processing: 7

  • quest/m0/adapters/README.md
  • quest/m2/api/release-0.4.md
  • rind-rcgen/Cargo.toml
  • rind-ring/Cargo.toml
  • rind-rustls/Cargo.toml
  • rind-str0m/Cargo.toml
  • rind/Cargo.toml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • rind back to 0.3.2 — the manifest returns to crates.io's published latest (verified: max_version 0.3.2; 0.3.3 was never published), so release-plz computes the next version itself from the ! commits, landing the pending breaks as 0.4.0.
  • Four adapters hand-set to their next patch — rind-rustls 0.23.4, rind-rcgen 0.14.4, rind-ring 0.17.4, rind-str0m 0.25.3; each verified as exactly one patch above its crates.io latest, which release-plz keeps as-is.
  • Cargo.lock regenerated to match the five manifests.
  • Quest docs — the two files now record the 2026-11-10 maintainer decision to let release-plz propose 0.4.0 rather than hand-setting it.

I audited the PR's version claims end to end rather than taking the body's word: every hand-set version matches crates.io as claimed, and the untouched adapters hold too — no ! commits since release 48c0908 for rind-dimpl, rind-jsonwebtoken, or rind-object-store, while rind-aws-lc-rs is already ahead of published (1.0.3 vs 1.0.2), which protects it from the two ! commits touching it. Every workspace rind requirement reads 0.3.2, matching the returned manifest, and dependencies_update = true in .release-plz.toml is what raises them alongside 0.4.0. cargo metadata --offline --no-deps and sh/adapter-versions.sh both pass locally.

Pullfrog  | View workflow run | Using glm-5.3 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 10, 2026
Merged via the queue into main with commit c64c209 Nov 10, 2026
11 checks passed
@moq-bot moq-bot Bot mentioned this pull request Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant