Repository navigation
fix(release): return rind to 0.3.2 and set four adapter patch versions by hand - #548
Conversation
This reverts commit 8b2dd4c.
release-plz proposed rind-rustls 0.24.0 and rind-rcgen 0.15.0, which the adapter version rule refuses: an adapter's version begins with its upstream's breaking part. Both changes restore upstream's API, so each is a patch release. Co-Authored-By: Claude <noreply@anthropic.com>
This reverts commit c124961.
… by hand main holds two breaking rind changes at a hand-set 0.3.3, which the release PR would publish as a patch. Setting 0.4.0 makes them, and any later one, publish under the right version. The adapters require rind 0.4.0 and keep their upstream's version prefix. Co-Authored-By: Claude <noreply@anthropic.com>
…ses 0.4.0 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 36 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
rindback to 0.3.2 — the manifest returns to crates.io's published latest (verified:max_version0.3.2; 0.3.3 was never published), so release-plz computes the next version itself from the!commits, landing the pending breaks as 0.4.0.- Four adapters hand-set to their next patch —
rind-rustls0.23.4,rind-rcgen0.14.4,rind-ring0.17.4,rind-str0m0.25.3; each verified as exactly one patch above its crates.io latest, which release-plz keeps as-is. Cargo.lockregenerated to match the five manifests.- Quest docs — the two files now record the 2026-11-10 maintainer decision to let release-plz propose 0.4.0 rather than hand-setting it.
I audited the PR's version claims end to end rather than taking the body's word: every hand-set version matches crates.io as claimed, and the untouched adapters hold too — no ! commits since release 48c0908 for rind-dimpl, rind-jsonwebtoken, or rind-object-store, while rind-aws-lc-rs is already ahead of published (1.0.3 vs 1.0.2), which protects it from the two ! commits touching it. Every workspace rind requirement reads 0.3.2, matching the returned manifest, and dependencies_update = true in .release-plz.toml is what raises them alongside 0.4.0. cargo metadata --offline --no-deps and sh/adapter-versions.sh both pass locally.
glm-5.3 | 𝕏

Returns
rindto its published 0.3.2 so release-plz proposes 0.4.0 from the!commits onmain, and sets four adapters to their next patch version by hand.Why
mainholds two breaking changes torind: the typedCbcIv(moq-dev/rind#530) and agreement keys that keep their public key (moq-dev/rind#529). Both merged whilerind/Cargo.tomlwas hand-set to an unpublished 0.3.3. release-plz keeps a version that differs from the published one, so release PR moq-dev/rind#511 proposed publishing both breaks as 0.3.3.With the manifest back at 0.3.2, release-plz computes the next version itself. Verified in release-plz's
next_versioncrate: a breaking commit bumps the minor on0.xunlessbreaking_always_increment_majoris set, and.release-plz.tomldoes not set it. #511 proposingrind-rustls0.24.0 etc. for!adapter commits shows the same rule in practice.#511 also proposed
rind-rustls0.24.0,rind-rcgen0.15.0,rind-ring0.18.0, andrind-str0m0.26.0, whichsh/adapter-versions.shrefuses: an adapter's version begins with its upstream's breaking part.Changes
rind0.3.3 back to 0.3.2 (crates.io's latest). Every workspace crate'srindrequirement stays 0.3.2; release-plz raises them withdependencies_update. The README keepsrind = "0.3", correct until 0.4.0 publishes.rind-rustls0.23.4 (moq-dev/rind#521, moq-dev/rind#529),rind-rcgen0.14.4 (moq-dev/rind#515, fix(rustls)!: rind-rustls is rustls's aws-lc-rs provider, item for item #521),rind-ring0.17.4 (moq-dev/rind#516, feat(agreement)!: keys keep their public key and algorithm #529),rind-str0m0.25.3 (fix(rcgen)!: KeyPair offers rcgen's KeyPair API #515).!commits since its last tag:rind-dimpl,rind-jsonwebtoken, andrind-object-storehave none;rind-aws-lc-rsis already hand-set to 1.0.3 onmain;rind-dartispublish = false.Decisions
Maintainer, 2026-11-10 (/quest-complete):
rindrequirement matches; the README's 0.4 snippet change is undone.Earlier, 2026-11-09 (moq-dev/rind#546): hold the release until the CPU-check removal, 0.4's third breaking change, lands. Still in force.
After this merges
rind0.4.0 and each adapter at a patch version; check before merging it, and hold it until the CPU-check removal is onmainand MoQ's PR (moq-dev/moq#8400) is ready.!on rind-dimpl, rind-str0m, rind-jsonwebtoken, and rind-object-store. Whichever of fix(adapters)!: rind-dimpl, rind-str0m, rind-jsonwebtoken, and rind-object-store match their upstream providers #519 and this PR merges second must hand-set those to their next patch too (rind-str0m is already 0.25.3 here).Public API and wire
None. The pending breaks publish as rind 0.4.0 instead of 0.3.3. Wire: none.
Checks
just checkpasses, includingsh/adapter-versions.sh.Models
Size: S
Implementer: Claude Code, claude-fable-5-2, high effort
Implementer: Claude Code, claude-opus-5-5 (iterate, S)
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)
Review
Rewritten by
quest reviewafter each round.01a1c69c-719b-7de0-91b4-e02e23d398d1, round 1The scoped diff consistently updates manifest and lockfile versions in line with the recorded release decision without changing cryptographic code; code inspection found no actionable defects, and builds and tests were intentionally not run.