[kixelated]

Problem

After moq-dev/rind#513 fixed the armv7 zeroing and Dart cross-target failures, three causes keep build.yml's nightly red on main (run 42918059953).

Approach

• Dart on macos-15-intel: the from-source test gets an explicit five-minute timeout. The default 30 seconds is shorter than a cold from-source build on that runner.
• Android rows and python qemu jobs: install qemu-user-binfmt. ubuntu-latest now resolves to 26.04, which has no qemu-user-static candidate.
• qemu rows: the planted allocation in heap_scratch goes through black_box, so the optimizer keeps it. Before the fix, the test failed to panic on riscv64 under qemu; after it, all nine heap_scratch tests pass there and on the host in release.

Verification

• just ci and just check pass locally.
• sh/dart.sh check passes, 30 tests. The from-source test takes about 3 seconds here, and a cold rind-dart cargo build about 4 seconds.
• Not checked here: the Intel Mac Dart row, the Android rows, the python qemu job, and the apt install on Ubuntu 26.04. The nightly checks them.

Decisions made without asking

• Dart: timeout over prebuilding. The quest recommended an explicit timeout over a CI step that builds first. AGENTS.md says never to work around a failure with a timeout. I read this one as a deterministic build budget rather than a flaky race, but a maintainer may prefer the prebuild step. Recommendation: keep the timeout.
• Timeout value: five minutes. Ten times the default. Not measured on the Intel runner, where the 30-second default was exceeded.

Impact

None. CI, test, and Dart test changes only; no public API or wire change.

Caused by

• moq-dev/rind#462: wrote the from-source Dart test body, with the default timeout
• moq-dev/rind#523: changed that test's header
• moq-dev/rind#432: installed qemu-user-static in build.yml, which ubuntu-latest no longer ships
• moq-dev/rind#496: installed qemu-user-static in python.yml, likewise
• moq-dev/rind#581: added the planted leak test that the optimizer removes on the qemu rows

Models

Size: XS
Implementer: Claude, claude-haiku-5-5, xhigh effort

Follow-ups

None.

🤖 Generated with Claude Code

(Written by Claude Haiku 5.5 with xhigh effort)

Review

Rewritten by quest review after each round.

• Reviewer: Codex, gpt-6.1-sol, low effort
• Session: 01a1c9d9-046d-7140-91b3-50988119318c, round 1
• Head: 6c367fd
• Base: origin/main at ff8bc24
• Score: 9/10, The scoped changes address CI package installation, the Dart test timeout, and the optimized-away leak-test allocation without an identifiable regression, though builds and tests were not run as instructed.
• Findings: none

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 92b206c6-095d-4d9b-92ed-9ac1a4dd639d

Commits

Reviewing files that changed from the base of the PR and between a4e2d01 and 6c367fd.

Files selected for processing: 5

• .github/workflows/build.yml
• .github/workflows/python.yml
• quest/m0/build-nightly.md
• rind-dart/test/hook_test.dart
• rind/tests/heap_scratch.rs

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn