Repository navigation
chore(quest): settle maintainer waits from /quest-unblock - #635
Merged
Merged
Conversation
Drop the upstream adoption PR quests (quinn, rustls's provider list, Bun and Bun SHA-3), and record that rind-openssl always builds with wipe. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
November 12, 2026 01:37
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 52 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settles the maintainer's waiting items from a
/quest-unblockpass on 2026-11-11.Changes
quest/m2/adoption/quinn.md,quest/m2/adoption/rustls-providers.md,quest/m1/bun.md, andquest/m2/adoption/bun-sha3.md. The m1 README drops its Bun half, and the adoption epic records the decision. Their draft PRs, moq-dev/rind#463 and moq-dev/rind#368, are closed with a comment.quest/m4/openssl-provider.md: records the wipe decision in its Plan and removes its## Waiting.No public API or wire impact.
Decisions
wipe: ✅ always build rind withwipeand wipe theOSSL_PARAMbuffers it fills (rejected: a build flag off by default; wiping nothing). The reason that keeps wiping opt-in, that safe Rust cannot read freed memory, fails where C shares the heap, and OpenSSL's own providers cleanse keys.quest/m2/upstream-reports.md): ✅ not yet (rejected: start now). The wait stays.Settled in other PRs during the same pass:
release.yml,publish), so cleared.pub.devenvironment now exists, deployable only fromrind-dart-v*tags, withAPP_CLIENT_IDand a new moq-botAPP_PRIVATE_KEY; tagrind-dart-v0.1.0is pushed.Models
Size: XS
Implementer: Claude Code, Opus 5.5, high effort
🤖 Generated with Claude Code
(Written by Claude Opus 5.5 with high)
Review
Rewritten by
quest reviewafter each round.01a1cd5a-28bc-78a2-aef6-4c14c2f3c630, round 2The incremental change clarifies the provider’s planned wiping policy and links to the existing default-feature decision quest, with no issues found.