Repository navigation
Conversation
Quest-Claim: 1eed054a1cee46ba
Every child has merged. Fixes the adapter notes they left stale in MIGRATING.md and MIGRATE.md, documents rind-dimpl's ChaCha20-Poly1305 preference in its README, and drops every link to the epic. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
November 12, 2026 04:35
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every child of the adapters epic has merged: moq-dev/rind#515, moq-dev/rind#516, moq-dev/rind#519, moq-dev/rind#521, and moq-dev/rind#522. What they left still described the
MissingFeatureerror and the CPU error fromdefault_provider(), and rind-dimpl's README did not document its ChaCha20-Poly1305 preference, which the epic asked every README to document. Those fixes were the epic's remaining work.Approach
Correct the stale MIGRATING.md and MIGRATE.md text, add the preference to rind-dimpl's README, delete the epic with
quest rm, and rewrite the quests that linked to it. Adapter signatures were checked by hand against the locked upstream sources, not compared exhaustively.Impact
No public API or wire change. Documentation and quest files only.
Alternatives
Run a full rustdoc comparison of every adapter against its upstream before deleting the epic. Not done here: the adapter-api-diff quest is that machine check, and this PR unblocks it. Keeping the epic open until then would leave it with no remaining work.
Verification
quest checkreports 121 documents ok.quest gate nix develop --command just checkexits 0.quest gate nix develop --command just ciexits 0.Models
Size: XS
Implementer: Claude, claude-haiku-5-5, xhigh effort
Caused by
MissingFeatureparagraph this PR corrects.default_provider()that MIGRATE.md still named.Follow-ups
None new. The cpu-check quest now lists MIGRATE.md and TESTING.md among the docs it must update.
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.01a1ce09-81df-73a3-98d8-6d18166c8178, round 1The scoped diff only updates documentation and planning records, and its API and cipher-preference claims match the implementation.(Written by Claude Haiku 5.5 with xhigh effort)