Repository navigation
chore(quest): plan Kotlin's native memory and bytes equality, and C++'s shared move-out - #433
Merged
Merged
Conversation
…'s shared move-out Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The lifetimes PRs left three follow-ups that no quest tracks:
Bytescompares by identity, so a record holding bytes equals only itself.Approach
Three quests, placed by consumer:
quest/m1/ffi-export/kotlin-native-memory.md[M]: moq's Android player reads frames in a loop, so it sits in moq's exporter epic. Measure first, then weigh GC accounting, a budget, or the copy threshold. It requires the lifetimes quest, since the backlog exists only once feat(ffi): read Kotlin's bytes only through methods, freed by the GC #432 lands.quest/m3/ffi-kotlin-bytes-equality.md[S]: generic correctness with no moq consumer yet.quest/m3/ffi-cpp-shared-future.md[S]: generic. It requires the lifetimes quest, and its Plan notes that it depends on feat(ffi): own C++ handles through smart pointers, shared where clones match #430's design and its openArcdecision.Choices made without asking (the user scoped these and asked to proceed): the milestone for each, and the sizes.
Impact
None: quests only.
Alternatives
Follow-ups
None.
Review
quest review), gpt-6.1-sol, medium effort, round 1 once638f54f7e35cb12e112e91c5e5ae13fbd0721b: no findings.🤖 Generated with Claude Code