Repository navigation
chore(quest): finish the lifetimes quest - #449
Merged
Merged
Conversation
Every item it lists has landed: Go's Close and bytes (#411), Swift's and Python's close (#427), Kotlin's bytes (#432), C++'s smart pointers (#430), and the lend's end (#429). C stays out of scope. Its dependents, Kotlin's native memory and C++'s shared move-out, are no longer blocked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 23 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes
quest/m1/ffi-export/lifetimes.md. Every item it lists has landed: Go'sCloseand bytes (#411), Swift's and Python'sclose(#427), Kotlin's bytes (#432), C++'s smart pointers (#430), and the lend's end (#429). C stays out of scope.#429 couldn't delete the lend item itself, since that item only existed in #427 at the time.
Removing it unblocks
quest/m1/ffi-export/kotlin-native-memory.mdandquest/m3/ffi-cpp-shared-future.md. Their stale links and "starts once #430 merges" note are updated.Public API: none.
Checks:
just checkandquest checkpass.🤖 Generated with Claude Code