Repository navigation
quest: plan generated inputs per differential case - #468
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 21 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A differential harness picks each case by its leading input bytes modulo its case count, from one seeded stream of random inputs, so adding a case changes which inputs every other case gets. In #436, adding a
stockcase sent the input421f00ff...tobuf::write_all, which hit thert.BytesMutreserve refusal on a zero-capacitytakethat no input had reached before. The fix landed in a PR that had nothing to do with it.Approach
One quest,
quest/m0/checks/case-inputs.md[S], under the checks epic: seed each case's generated inputs from its name, through theopsa harness exports, so adding, removing, or reordering a case leaves the other cases' inputs unchanged. It coversstock,lang, andtask, which sharets/tests/differential.ts.Impact
None: quests only.
Alternatives
stock: the generator and the modulo pick are shared by every differential harness, so each would keep the same problem.Follow-ups
None.
Review
quest review), gpt-6.1-sol, medium effort, round 1 on6a108622f454db445a76da3e4ebb300801dbbabc: no findings.just checkpasses locally.(written by Claude Opus 5.5)
🤖 Generated with Claude Code