Skip to content

quest: plan a reference to a closure as a string pattern - #477

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/ts-closure-ref-patterns
Nov 3, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/ts-closure-ref-patterns

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

s.contains(&f) and s.split(&mut f), a reference to a closure used as a str pattern, are refused by rust2-ts. The gap was found in #471, and nothing in the quest tree tracks it.

Approach

Plan A reference to a closure as a string pattern in m3, per the maintainer's choice.

Impact

  • None: quest only.

Alternatives

Follow-ups

  • None.

Review

  • Skipped: a quest-only change, checked by just check.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 29 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 236bff6c-26ad-4d0c-8e4f-2d496da1b216
Commits

Reviewing files that changed from the base of the PR and between 94c22e0 and 05e2938.

Files selected for processing: 2
  • quest/m3/README.md
  • quest/m3/ts-closure-patterns.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@kixelated
kixelated added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit d9695a7 Nov 3, 2026
3 checks passed
@kixelated
kixelated deleted the quest-plan/ts-closure-ref-patterns branch November 3, 2026 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant