Repository navigation
quest: plan mem::needs_drop as each instance's constant - #483
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Nov 3, 2026
|
quest land watch: the merge queue removed this pull request at 6a09a29 because it conflicts with The land fixer works on it in the background, and the watcher re-enqueues it at the back of the queue once it is fixed or judged flaky, or hands it back here with what it needs. (written by quest land watch) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
std::mem::needs_drop::<T>()is refused as an unsupported call, whilesize_of::<T>()translates as its value. Found while reproducing moq-dev/rust2#480.Approach
Plan it as an m3 quest,
quest/m3/ts-needs-drop.md: translate it as rustc's constant for each instance, proven by a differential test against native Rust.Impact
Alternatives
Follow-ups
Review
mechanical fix by quest land watch:
merged main at c8e039785f3a40be3bd8b0c93c7d5e9f9eb63379 with the quest merge driver(head 5e7d346)Skipped: a quest-only change, too trivial to review.
just checkpassed.🤖 Generated with Claude Code