Repository navigation
quest: plan Debug of a LazyCell or a LazyLock, and test Cell's Debug order with a crate's own writer - #491
Merged
Conversation
…order with a crate's own writer Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 42 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#484 left two follow-ups:
DebugofLazyCellandLazyLockwas unchecked. A probe onmainrefuses both: "unsupported call to<LazyCell<u8, ..> as Debug>::fmt", and the same forLazyLock.CellDebugfix (read the value before writing the prefix) has no differential test, because only a crate's ownfmt::Writewith placeholders can observe the order, and the translator refuses that.Approach
quest/m3/ts-lazy-debug.md:LazyCell(..)/LazyLock(..), or(<uninit>)before a force, as std writes them. It notes the runtime's#privatestate needs a reading method, asonceDebughas. Listed in m3 after the related lazy-writes quest.quest/m3/ts-fmt-calls.mdalready plans a crate's ownfmt::Writewith placeholders. Rather than duplicating it, it gains a step: a differential case for aCell'sDebuginto a writer that sets that cell.Impact
Alternatives
fmt::Writequest: it would duplicatets-fmt-calls.md.Follow-ups
Review
quest review).🤖 Generated with Claude Code