Repository navigation
chore(quest): plan function pointer patterns and char methods - #503
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 50 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Testing #495 turned up two gaps that are out of its scope: a function pointer or boxed closure used as a
strpattern, andcharmethods that have no mapping.Approach
Two new m3 quests. I probed each case on main at
7c41f2b1with a scratch crate first, so both quests record observed results:quest/m3/ts-fn-patterns.md:fn(char) -> bool(by value and&),Box<dyn FnMut(char) -> bool>(by value and&mut), andBox<{closure}>are all refused as "unsupported call" bycontainsandsplit.quest/m3/ts-char-methods.md: no existing quest coveredcharmethods. It lists each unmapped method the probe refused, called and as a value (classes, case, escapes, UTF-16 and UTF-8 encoding,from_digit,TryFrom<u32>). It also lists the mapped methods that already translate as values, so the gap is the mapping, not the function value.Impact
Alternatives
Follow-ups
Review
a920aa79: no findings.8d1ec238adds only a conflict-free merge oforigin/main;just checkpassed on it.🤖 Generated with Claude Code