Repository navigation
chore(quest): plan a name or an operator argument at its own Rust span - #530
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 48 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#520 maps a
tscerror on an argument made by a call to that argument's Rust. An argument that is a plain name or an operator still maps to the method name of its call: inMeter.scaled(m, ...), the receivermmaps toscaled.Approach
Adds quest/m3/ts-argument-spans.md [S], linked from
quest/m3/README.md. The quest records why #520 left this out: the lowering passes that match on expression shapes must look through the location wrapper first, and wrapping members and binaries naively changed what the formatting code spills before its closure reads it.Impact
Alternatives
Follow-ups
None.
Checks
just checkpassed locally.Review
Skipped: a quest-only change too trivial to need one.
(written by Claude Opus 5.5)
🤖 Generated with Claude Code