Skip to content

chore(quest): record the pushed Vec capacity decision, measuring a wrapper first - #535

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/ts-vec-clear-capacity-decision
Nov 3, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/ts-vec-clear-capacity-decision

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

The maintainer decided quest/m3/ts-vec-clear-capacity.md on 2026-11-03. That decision conflicts with the 2026-11-02 one, recorded in ts-vec-exact-capacity.md, to keep only std's capacity guarantees: clear and truncate keeping the capacity is itself a documented guarantee.

Approach

  • Records the prompt in the quest's Plan, with ✅ on the pick: measure ts-vec-exact-capacity's untried wrapper first, then choose.
  • The Plan now opens with that measurement: a Vec object holding its own length and capacity over its array, timed on push/stack and the other TS benchmarks in Node, Chrome, Bun, and Firefox. The comparison is peak tracking's 1.24x, 1.11x, 2.3x, and 2.8x. The numbers come back to choose between the wrapper, fixing it at the measured cost, and documenting the divergence.
  • The Plan notes the quest may merge with ts-vec-exact-capacity.md once measured, since a wrapper that holds its own capacity would give std's exact capacity too.
  • One sentence in the Goal says the measurement decides how, or whether the divergence is documented instead.
  • ts-vec-exact-capacity.md's untried-wrapper bullet now points to this quest as the one that measures it first.
  • moq-dev/rust2#527 has landed, so the reference to ts-clone-from-capacity.md under ## Related is now a path link. This was chore(quest): plan keeping a pushed Vec's capacity as it shrinks #531's follow-up.

Impact

  • Public API: none, quests only.

Alternatives

  • Fold this quest into ts-vec-exact-capacity.md now: whether they share one fix depends on the measurement, so they stay separate until then.

Follow-ups

None.

Review

Skipped: a quest-only change of planning prose that records a maintainer decision. just check passed on head b600a9ab607a766c9b9e064ceed5d2482d323a66.

🤖 Generated with Claude Code

…apper first

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 30 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: abdea64d-7a03-4efd-a955-448a49a66a9b
Commits

Reviewing files that changed from the base of the PR and between 2283c19 and b600a9a.

Files selected for processing: 2
  • quest/m3/ts-vec-clear-capacity.md
  • quest/m3/ts-vec-exact-capacity.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@kixelated
kixelated added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit 85cb7ff Nov 3, 2026
3 checks passed
@kixelated
kixelated deleted the quest-plan/ts-vec-clear-capacity-decision branch November 3, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant