Repository navigation
chore(quest): record the pushed Vec capacity decision, measuring a wrapper first - #535
Merged
Merged
Conversation
…apper first Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 30 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The maintainer decided
quest/m3/ts-vec-clear-capacity.mdon 2026-11-03. That decision conflicts with the 2026-11-02 one, recorded ints-vec-exact-capacity.md, to keep only std's capacity guarantees:clearandtruncatekeeping the capacity is itself a documented guarantee.Approach
ts-vec-exact-capacity's untried wrapper first, then choose.Vecobject holding its own length and capacity over its array, timed onpush/stackand the other TS benchmarks in Node, Chrome, Bun, and Firefox. The comparison is peak tracking's 1.24x, 1.11x, 2.3x, and 2.8x. The numbers come back to choose between the wrapper, fixing it at the measured cost, and documenting the divergence.ts-vec-exact-capacity.mdonce measured, since a wrapper that holds its own capacity would give std's exact capacity too.ts-vec-exact-capacity.md's untried-wrapper bullet now points to this quest as the one that measures it first.ts-clone-from-capacity.mdunder## Relatedis now a path link. This was chore(quest): plan keeping a pushed Vec's capacity as it shrinks #531's follow-up.Impact
Alternatives
ts-vec-exact-capacity.mdnow: whether they share one fix depends on the measurement, so they stay separate until then.Follow-ups
None.
Review
Skipped: a quest-only change of planning prose that records a maintainer decision.
just checkpassed on headb600a9ab607a766c9b9e064ceed5d2482d323a66.🤖 Generated with Claude Code