Skip to content

quest(m3): plan BufMut on byte slices, associated-type fields, and Box::new_uninit - #626

Merged
moq-bot[bot] merged 2 commits into
mainfrom
quest-plan/m3-follow-ups
Nov 7, 2026
Merged

moq-bot[bot] merged 2 commits into
mainfrom
quest-plan/m3-follow-ups

Conversation

@kixelated

@kixelated kixelated commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Plans three m3 quests from the suggested follow-ups of queued and landed PRs, each a gap rust2 aims to close under m3's support-all-of-std decision.

Changes

Decisions

Settled with the maintainer on 2026-11-07:

  • BufMut on byte slices: ✅ m3 (rejected: m2, drop).
  • Fields typed by an associated type: ✅ m3, as a core language gap (rejected: m2, drop).
  • A Box of one uninitialized value: ✅ m3, in the ts-unsafe epic (rejected: m2, drop).

A fourth follow-up, #553's generic rules, went to moq-dev/quest as moq-dev/quest#529.

Public API: none.

Validation

quest gate just ci passes locally.

Models

Size: S
Implementer: Claude Code, claude-opus-5-5, high effort

(Written by Claude Opus 5.5 with high effort)

🤖 Generated with Claude Code

Review

mechanical fix by quest land watch: merged main at b86a1869b5eb4385a825144d3c0892734247be91 with the quest merge driver (head fbe5f56)

Rewritten by quest review after each round.

  • Reviewer: Codex, gpt-6.1-sol, medium effort
  • Session: 01a1b383-e724-78e2-9365-e95cc52e6e06, round 1
  • Head: 96ca7c0
  • Base: origin/main at a9eb87c
  • Score: 10/10, The specified diff adds three scoped planning documents and valid parent-index links, with no executable changes or actionable defects.
  • Findings: none

…x::new_uninit

Follow-ups of #611, #600, and #606.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@pullfrog

pullfrog Bot commented Nov 7, 2026

Copy link
Copy Markdown

Pullfrog  | Review this ➔

@kixelated
kixelated marked this pull request as ready for review November 7, 2026 00:59
@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1ee5254a-891c-4565-9db6-85151d94d85e
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 96ca7c0

No actionable findings. Reviewed all five changed planning files and the m3/unsafe parent plans. The three goals have concrete native-Rust differential-test outcomes, the mutable-slice hypothesis is explicitly marked for reproduction, and each new quest is linked from the appropriate parent.

Direction: no change requested for this planning-only diff.

Verification limits: GitHub source inspection only; I did not run quest validation, builds, tests, or independently verify the PR author's local-check results. No executable behavior changed.

(Written by OpenAI)

@kixelated
kixelated added this pull request to the merge queue Nov 7, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 7, 2026
@moq-bot

moq-bot Bot commented Nov 7, 2026

Copy link
Copy Markdown

quest land watch: the merge queue removed this pull request at 96ca7c0 because it conflicts with main (merge_conflict).

The land fixer works on it in the background, and the watcher re-enqueues it at the back of the queue once it is fixed or judged flaky, or hands it back here with what it needs.

(written by quest land watch)

@moq-bot
moq-bot Bot enabled auto-merge November 7, 2026 01:20
@moq-bot

moq-bot Bot commented Nov 7, 2026

Copy link
Copy Markdown

quest land watch: armed auto-merge on this pull request at fbe5f56, so it joins the back of the merge queue once its required checks pass, with main at b86a186 merged in by the quest merge driver.

(written by quest land watch)

@moq-bot
moq-bot Bot added this pull request to the merge queue Nov 7, 2026
Merged via the queue into main with commit 1acf4f2 Nov 7, 2026
7 checks passed
@moq-bot
moq-bot Bot deleted the quest-plan/m3-follow-ups branch November 7, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant