Skip to content

quest: plan a Pin of a crate's own Deref type - #666

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/ts-pin-own-deref
Nov 8, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/ts-pin-own-deref

Conversation

@kixelated

@kixelated kixelated commented Nov 8, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Plans the follow-up of moq-dev/rust2#621, now queued: A Pin of a crate's own Deref type [S]. Pin::new(OwnPtr(Cell::new(0))) with old.get() through it fails tsc (TS2739), because Pin<P>'s deref is typed as P itself. It's a translator bug in safe Rust.

Decisions

🤖 Generated with Claude Code

(Written by Claude Opus 5.5 with high effort)

Review

Rewritten by quest review after each round.

  • Reviewer: Codex, gpt-6.1-sol, low effort
  • Session: 01a1b902-4d08-7620-80b3-8655c003be0b, round 1
  • Head: f0ec3f5
  • Base: origin/main at ed8ca86
  • Score: 10/10, The specified diff adds only a deferred quest and its index link, with no actionable defects or executable behavior changes.
  • Findings: none

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@pullfrog

pullfrog Bot commented Nov 8, 2026

Copy link
Copy Markdown

Pullfrog  | Review this ➔

@kixelated
kixelated marked this pull request as ready for review November 8, 2026 02:35
@coderabbitai

coderabbitai Bot commented Nov 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 49 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8b5d846f-a91a-40f1-9dc4-f5698e1986af
Commits

Reviewing files that changed from the base of the PR and between ed8ca86 and f0ec3f5.

Files selected for processing: 2

  • quest/m3/README.md
  • quest/m3/ts-pin-own-deref.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated added this pull request to the merge queue Nov 8, 2026

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head f0ec3f5 against base ed8ca86.

No actionable findings in this two-file planning change. The new quest and its m3 index entry consistently describe a safe-Rust Pin

/custom-Deref translation gap, with both TypeScript type-checking and native differential behavior as acceptance criteria. Deferring it in m3 is consistent with that milestone's documented policy for std support without a current moq consumer.

Direction: preserve both checks when implementing the fix; type-checking alone would not establish that the custom Deref implementation actually runs. This PR plans that work and does not claim to fix the translator.

Verification limits: static GitHub-only review of the full diff and milestone context. I did not reproduce TS2739, run tests, or verify the reported consumer coverage. This is a COMMENT review, not approval.

(Written by review (OpenAI))

Merged via the queue into main with commit eeec4ff Nov 8, 2026
7 checks passed
@kixelated
kixelated deleted the quest-plan/ts-pin-own-deref branch November 8, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant