Skip to content

quest: plan a single Vulkan loader and the X11 GPU path on NVIDIA - #60

Merged
kixelated merged 2 commits into
mainfrom
quest-plan/cef-gpu-fixes
Nov 6, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest-plan/cef-gpu-fixes

Conversation

@kixelated

@kixelated kixelated commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Follow-ups from #59, picked by the maintainer through /quest-plan on 2026-11-05.

Decisions

  • Vulkan: ✅ m0 quest, don't ship CEF's loader; m0 quest, dev shell sets VK_DRIVER_FILES; skip.
  • X11 on NVIDIA: ✅ m0 quest, fix GBM and fail loud; m0 quest, CPU fallback only; skip.
  • Milestone: ✅ m0, by the fixes rule; m1.

Review

  • Round 1 (Codex gpt-6.1-sol, medium) on 1a34ee3: no findings.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 5, 2026 20:49
@pullfrog

pullfrog Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

OpenCode Zen returned an error, so this run stopped. If it names your key, plan or balance, fix that with the provider or pick another model.

Free usage limit reached. Connect a provider or subscribe to OpenCode Go to keep going, or switch models.

Pick another model →

Pullfrog  | Rerun failed job ➔ | View workflow run | via Pullfrog | Using big-pickle (free)

@coderabbitai

coderabbitai Bot commented Nov 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 34 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 657b75f5-2417-4535-9912-b0192d49f5d7
Commits

Reviewing files that changed from the base of the PR and between c6b1fb7 and 1a34ee3.

Files selected for processing: 3

  • quest/m0/README.md
  • quest/m0/cef-vulkan-loader.md
  • quest/m0/cef-x11-nvidia.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated kixelated left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head: 1a34ee3ae1049c1761c1539d15feef0a0a88bdf6.

No actionable findings in this documentation-only change. The two plans match the unresolved cases documented in #59 and are linked correctly from m0.

Direction: continue as scoped. Removing the shadowing Vulkan loader targets the dependency-resolution problem rather than adding a development-only workaround. Investigating CEF's missing GBM device first, with an explicit startup capability decision and a visible CPU fallback, fits the existing helper design. The separate Mesa investigation remains covered by its existing quest.

Verification: inspected all three changed files, the surrounding quest plans, Nix/build configuration, browser setup and browser tests. GitHub-only static review; no builds, tests, GPU checks, or quest context execution. Read the pinned context source instead. The Check workflow is still running, and runtime correctness of the proposed fixes is not established by this PR.

@kixelated
kixelated merged commit efd5ca3 into main Nov 6, 2026
2 checks passed
@kixelated
kixelated deleted the quest-plan/cef-gpu-fixes branch November 6, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant