[kixelated]

Summary

Plans two m0 fix quests suggested by moq-dev/studio#81. Both join m0 under the rule that fixes join m0:

• Unpublishing a scene ends its broadcast cleanly [S]: unpublishing can end viewers' video with Unroutable, which also makes a_published_scene_has_its_own_broadcast flaky (3 failures in about 33 runs). Unpublishing waits for the relay the way quitting already does.
• A media file's sound plays with its pictures [S]: media sources write sound a bus latency late, so it trails their pictures by about 45 ms.

No public API or wire impact; quest files only.

Decisions

The maintainer was away under /afk, which approved taking the recommended option:

• Unpublish race: ✅ plan it, m0; plan it, m1; drop it
• Fix site: ✅ the studio waits for the relay as Output::close does; moq-net delivers a finished track's end after its broadcast closes
• Media A/V offset: ✅ plan it, m0; plan it, m1; drop it

Review

Codex (gpt-6.1-sol, medium effort), round 1 on head a8261c8c1fbf8194277c8e8630f32a5526365972: no findings.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

[pullfrog]

  ^{｜ Review this ➔}

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 20 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 9f3e5ee6-f818-4617-94cb-c5ddceea7b64

Commits

Reviewing files that changed from the base of the PR and between 2821f0d and a8261c8.

Files selected for processing: 3

• quest/m0/README.md
• quest/m0/media-av-sync.md
• quest/m0/unpublish-clean.md

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[kixelated]

Automated review by review (OpenAI)

Reviewed head a8261c8c1fbf8194277c8e8630f32a5526365972 against base 2821f0da677c011e78f41e8a12a62cbb94c7c83a.

No actionable findings in these two follow-up plans. The source supports both problem statements: scene retirement waits for local encoder completion before closing its broadcast, while shutdown separately drains relay sessions; media playback currently writes audio when its picture is due, whereas broadcast playout accounts for bus latency. The quests state observable outcomes, cover unpublish/rename/removal and the relevant media outputs, and keep implementation work separate from this documentation change.

Direction: retain these focused m0 fixes and the proposed clean-end and media-clock regression checks. No plan changes requested.

Verification limits: GitHub-only static review of all three changed documents and the relevant engine, media-source and playout code. I read the pinned quest context as source but did not execute quest context, quest check, tests or CI. The reported flake counts and timing measurements were not independently reproduced. COMMENT only, not approval.

(Written by review (OpenAI))

[kixelated]

Pick (/quest-complete, maintainer away under /afk, recommended option): ✅ Merge. It only plans two m0 quests, Check passed, the Codex review found nothing, and CodeRabbit skipped on its rate limit.

(Written by Claude Opus 5.5)