Skip to content

quest: move viewer-side composition to m2 behind publish-independently - #97

Merged
kixelated merged 5 commits into
mainfrom
quest/m1/compose/layout
Nov 7, 2026
Merged

kixelated merged 5 commits into
mainfrom
quest/m1/compose/layout

Conversation

@kixelated

@kixelated kixelated commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Replans Layout track: the viewer-side composition epic moves to m2, behind Published independently.

Summary

Since 2026-11-04 (moq-dev/studio#21, moq-dev/studio#30), the program is the default and no source's track reaches the relay. rs/moq-scene/src/publish.rs keeps every source track in a local broadcast the studio never announces. A source reaches viewers only once Published independently ships, and that quest is in m2. So nothing in m1 can fetch a track a layout names, and the browser, server, and controls quests have nothing to compose.

Changes:

  • quest/m1/compose/ moves to quest/m2/compose/. Links in the m0, m1, and m2 READMEs and in publish-independently.md follow it. The epic leaves m1's Required list and joins m2's, after Published independently.
  • layout.md: Published independently becomes its first Required. The Plan records the decision and the rejected options, and says the quest is replanned around the epic's reference picture once that lands. The ## Waiting item is cleared.
  • browser.md and server.md need fetchable source tracks, but both already Require the layout. controls.md Requires browser.md. All three now wait on Published independently through the layout, so they don't repeat the link. The epic README says so.
  • The m1 Goal no longer promises viewer composition.

Decisions

  • Picked 2026-11-07 (maintainer away under /afk, recommended option; comment): move the compose epic to m2, make Published independently the layout's first Required, and replan the layout once it lands. Rejected: replanning now around the program with independently published sources layered over it, and building the full-scene layout as written.
  • Made without asking: moved the files by hand (git mv plus link rewrites). quest mv refuses to move a quest its own open claim names, and this PR is that claim. After merge the quest lives at quest/m2/compose/layout.md, and this branch name no longer matches it.

Public API and wire impact

None: quest files only.

Validation

  • quest check --base origin/main: 37 documents ok.
  • quest unblocked quest/m2/compose/layout.md and quest unblocked quest/m2/compose/browser.md: both are blocked, through Published independently and the layout.
  • just check / just test not run: the diff touches only quest Markdown. Merged origin/main (a461c84) without conflicts.

Review

  • Reviewer: Codex (quest review), gpt-6.1-sol, medium effort.
  • Head: b4184149722beaf0dfabd088e8f28dad072f2ea0, round 1.
  • Findings: none.

(Written by Claude Opus 5.5)

Quest-Claim: 3570705f9a7b3a34
@pullfrog

pullfrog Bot commented Nov 7, 2026

Copy link
Copy Markdown

Pullfrog  | Review this ➔

… a source track

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Layout track quest(m1/compose/layout): wait on a replan of the layout track Nov 7, 2026
@kixelated

Copy link
Copy Markdown
Contributor Author

Pick (/quest-complete, maintainer away under /afk, recommended option): ✅ Move the compose epic to m2, with "Published independently" (quest/m2/publish-independently.md) as the layout's first prerequisite, and replan the layout once that lands. Nothing in m1 can read a layout today, and the picture viewers end up with decides what it carries. Check browser.md, server.md and controls.md in the same pass. Rejected: replanning now around program-plus-overlays, and building it as written.

(Written by Claude Opus 5.5)

@kixelated kixelated changed the title quest(m1/compose/layout): wait on a replan of the layout track quest: move viewer-side composition to m2 behind publish-independently Nov 7, 2026
@kixelated
kixelated marked this pull request as ready for review November 7, 2026 16:55
@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 42 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5f84890e-1f19-4699-a6ce-6d68a10c9661
Commits

Reviewing files that changed from the base of the PR and between 57eeb09 and 2107c21.

Files selected for processing: 9

  • quest/m0/README.md
  • quest/m1/README.md
  • quest/m2/README.md
  • quest/m2/compose/README.md
  • quest/m2/compose/browser.md
  • quest/m2/compose/controls.md
  • quest/m2/compose/layout.md
  • quest/m2/compose/server.md
  • quest/m2/publish-independently.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated kixelated left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed head b4184149722beaf0dfabd088e8f28dad072f2ea0 against base a461c842511aa3664af049ff78209854e28378cf.

No actionable findings. The prerequisite chain is acyclic: layout requires independent publication, browser/server require layout, and controls require browser. The publication quest's backlink is only Related. Local source-track publication supports the stated dependency, and the reference-picture redesign was already deferred at base. The moved documents' links resolve; no old quest/m1/compose paths remain in the quest tree or user README.

Direction: keeping composition behind fetchable source tracks avoids implementing an unusable layout, while preserving the explicit replan before implementation.

Verification: GitHub-only static review of all nine changed documents, surrounding quest hierarchy, publication source and history. Repository guidance and pinned quest context were read as source; no quest context, quest check, builds or tests were executed.

(Written by review (OpenAI))

@kixelated

Copy link
Copy Markdown
Contributor Author

Pick (/quest-complete, maintainer away under /afk, recommended option): ✅ Merge, keeping the hand move (quest mv refuses a quest its own claim branch names). The OpenAI review found nothing. Merged main (#93, #96).

(Written by Claude Opus 5.5)

@kixelated
kixelated merged commit e41b4a0 into main Nov 7, 2026
3 checks passed
@kixelated
kixelated deleted the quest/m1/compose/layout branch November 7, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant