Skip to content

fix(ci): resolve builder 7-Zip for Windows startup - #152

Merged
EvilWeasel merged 1 commit into
mainfrom
fix/windows-startup-7zip-20261113
Nov 13, 2026
Merged

EvilWeasel merged 1 commit into
mainfrom
fix/windows-startup-7zip-20261113

Conversation

@EvilWeasel

@EvilWeasel EvilWeasel commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

The Windows desktop startup check failed before launching the app because 7z was absent from the runner's PATH.

Resolve 7-Zip through the installed desktop electron-builder's own toolset resolver, verify the resolved executable exists, and use that path for both installer and application-payload extraction. The existing extraction failures, launch/version checks and cleanup still run normally.

Validation:

  • Reproduced the unchanged PowerShell step failing with 7z CommandNotFound.
  • On Boat, the actual updated step extracts two small nested fixture archives with the builder-provided Linux binary and paths containing spaces. Invalid resolver paths, corrupt installers and a failing launch boundary still fail and clean up. This checks the shell contract; the Windows app-launch boundary is stubbed.
  • All 28 existing Nightly workflow contract tests passed. The normal exact-base integration check passed formatting and its configured focused test; staged format/lint hooks passed.
  • Parsed workflow comparison confirms that only this startup step's resolver and two command paths changed. The actual Windows desktop startup remains for the normal release workflow.

Model: GPT-6.1 Sol. Harness: Codex.


Run Proof
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T15:35:37.208919Z 3cc9605 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@EvilWeasel
EvilWeasel merged commit f2c26b0 into main Nov 13, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant