Repository navigation
fix(ci): extract the embedded Windows app payload - #153
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows startup check opened the installer as its embedded application 7z archive, then looked for the NSIS runtime path
$PLUGINSDIR/app-64.7zinside that archive. The filter selected zero files and the payload presence check correctly stopped the job before app startup.Extract that embedded 7z directly from the exact selected installer into a fresh, unique scratch directory. Require
Morrowbyte.exeto be a file before hashing and running the existing desktop smoke with the expected version. The Builder binary resolver, actual launch/version checks, process cleanup and diagnostics remain in place.Validation:
Model: GPT-6.1 Sol. Harness: Codex.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.