Repository navigation
fix(server): prepare rollback before staging successive updates - #154
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e3fc627e24
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After a committed A→B update, runtime retention still protects A while the next update stages C. A normal update therefore fails under the existing 1-GiB limit even when B+C fit. A versioned Linux launcher or recorded CLI link can independently keep A referenced.
Change
The launcher now durably prepares the current, fully verified B runtime as the rollback baseline before downloading C. Preparation survives download failure, cancellation and restart; pending transactions, active process references, runtime hashes, profile compatibility, storage accounting and native preflight retain their guards. Commit acknowledgement follows the durable commit before post-commit qualification and cleanup.
Linux services use a stable launcher entry, and the persistent launcher hands its executable to the selected runtime at the existing update boundary. Service commands can select an exact custom unit and refuse another T3 home's unit; the stopped-update handler verifies the selected unit and base before invoking the updater. An explicit
service update-stopped VERSIONcommand lets an up-to-date CLI bootstrap older stopped installations through the same preparation, installer, profile preflight, database backup and trial path. It does not stop a running server.Scope and approval
Owner-requested follow-up to #149 for the demonstrated successive-update budget blocker and the existing custom-unit installations that need the supported bootstrap path. Runtime limits, archive streaming, checksum verification and retention ownership remain unchanged.
Verification
vp run check:integration --exact-base …: format, lint and all 98 adjacent tests in seven existing files passed. Server packagevp run typecheckpassed. Existing cases cover custom-unit isolation, state preservation, preparation IPC and forward/rollback launcher handoff.No new native or product build was made for these checks. Fixture regressions and real published-payload evidence are separate.
Model: GPT-6.1 Sol (ultra, priority), Codex harness through T3 Code.