Repository navigation
fix(registry): migrate Smart Link listing to v2 - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #4 added
gricials112.smart-link@1.0.5using the former root-levelname,description, andfeaturesfields. The current registry v2 schema rejects those fields and requireslisting, so the merged entry prevents registry validation and publishing.Move the existing English and Chinese copy into
listing.localizations(en-USandzh-CN) withdefaultLocale: "en-US". Replace the fixed published-entry count assertion with a non-empty catalog check, so adding plugins does not require editing this test. Schema, publisher-policy, default-locale, and ID-order checks still apply to every entry. All original copy, package identity, version, download URL, checksum, size, and permissions are preserved.Validation: typecheck, all 106 tests, validation of all four entries, aggregation (11,697 UTF-8 bytes), and
git diff --checkpass. A separate comparison confirms that all source copy and all non-listing fields are unchanged.Follow-up to #4.