Conversation
…n heuristics For a root-level file (e.g. `mach`), the parent directory is the repository root, so the sibling search walked the entire tree and scheduled every test manifest. Skip the sibling search for such files.
Files directly inside large directories (e.g. dom/moz.build, browser/moz.build) are close to hundreds of test manifests, which makes the sibling heuristic uninformative and schedules far too much. Cap the number of manifests the sibling search may return for a single path at 42; above that, leave the decision to the model.
bhearsum
approved these changes
Sep 21, 2026
bhearsum
left a comment
bhearsum
left a comment
There was a problem hiding this comment.
This seems like a plausible way to improve this.
How will we measure how well this is working?
Collaborator
Author
|
@bhearsum I will write a script to retrieve backout data and analyze effectiveness (also comparing different strategies, thresholds, etc.). |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @bhearsum