Repository navigation
opensl: implement get_min_latency and get_preferred_sample_rate - #863
Merged
Merged
Conversation
Use JNI to call Android's AudioManager.getProperty() API to query the OUTPUT_FRAMES_PER_BUFFER and OUTPUT_SAMPLE_RATE properties, respectively. These are available from API level 17 onwards, matching the existing JNI usage for getOutputLatency(). On earlier API levels CUBEB_ERROR_NOT_SUPPORTED will continue to be returned.
Contributor
Author
|
This is for firefox: https://phabricator.services.mozilla.com/D332484 |
jamienicol
commented
Oct 12, 2026
| { | ||
| XASSERT(ctx && latency_frames); | ||
| output_latency_function * ol = ctx->p_output_latency_function; | ||
| if (!ol || !ol->from_jni) { |
Contributor
Author
There was a problem hiding this comment.
I don't love piggybacking on the ouptut_latency_function to obtain the JNI. Fortunately the output latency function and the new ones we're adding both have the same minimum API level so it works out, but I'm open to suggestions on how to improve this.
Collaborator
There was a problem hiding this comment.
Good enough. The OpenSL ES backend is legacy. AAudio is what we're using mostly (I hope?).
padenot
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use JNI to call Android's AudioManager.getProperty() API to query the OUTPUT_FRAMES_PER_BUFFER and OUTPUT_SAMPLE_RATE properties, respectively.
These are available from API level 17 onwards, matching the existing JNI usage for getOutputLatency(). On earlier API levels CUBEB_ERROR_NOT_SUPPORTED will continue to be returned.