Repository navigation
fix(web): keep a side chat's first question if the panel closes during send - #315
Closed
cursor[bot] wants to merge 1 commit into
Closed
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
…g send The unused-delete guard was noted only inside startThreadTurn, after the title, settings, and attachment round trips. Closing the panel in that window deleted the side chat before the turn was submitted, so the question could not be reopened. Note the send when it is committed. Co-Authored-By: mubeda <1380447+mubeda@users.noreply.github.com>
github-actions
Bot
added
size:S
vouch:trusted
mubeda
force-pushed
the
fix/side-chat-send-survives-close
branch
from
November 8, 2026 23:41
b8ac9d8 to
efe222a
Compare
Owner
|
Closed at the maintainer's request after the v0.15.3 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
A side chat's first send is noted when the user commits it, before the title, settings, and attachment round trips. Closing the panel during those round trips archives it instead of deleting it.
Why
thread.deletewithonlyIfUnusedremoves a side chat that has no message or turn yet. The client was supposed to note a send before it went out, but the note lived insidestartThreadTurn, after those awaits. Closing the panel in that window deleted the thread. The turn then failed, and Reopen closed chat does not list a deleted panel, so the question was gone.The note now happens when the send is committed, including a plan follow-up whose settings are saved before the turn. The turn call still notes the send, which covers the attachment replay.
Checklist