Repository navigation
CI build times: measure the real causes, split Windows server tests, verify symbol dumps - #370
Merged
Merged
Conversation
…364) dump_syms logs a failed unwind table and exits 0. On macOS the dSYM's unwind section header has no data and fails this way while the binary's tables are read in full; an error in the binary's own tables would truncate the records instead. When an error is logged, dump the binary alone: fail if it errors too or the STACK record counts differ. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…ript (#363) Passes a per-package Cargo --config override for bibcode-server and bibcode-desktop, which leaves every dependency fingerprint unchanged. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…ore cores (#363, #368) A Windows native row compiled bibcode-server five times. The server tests and the test target check now run in server_tests_windows, without -j 2. CI bundle builds pass --workspace-codegen-units 16 and print a time and memory heartbeat. Pull requests no longer save pnpm store cache entries. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…367) Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
… before a spawn error Review findings: the heartbeat left its sleep holding the step's log open, a dump_syms spawn error hid what the tool had logged, and one sentence in the CI guide still said native CI builds the full release profile. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
A first spawn can stall for seconds on a loaded Windows runner (#367), which would fail the new test for the reason it exists to report. Also document the new bundle flag and the dump check in the scripts reference. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
A manual run has no base or before commit, so it scanned the whole history of the branch and failed on findings that were already there. That made the documented way to run the full set on a pull request always fail Secrets. Approved by the repository owner on 2026-11-14. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…t spawn (#367) Reproduced on fresh Windows arm64 runners: 1 of 80 cold runs failed with the issue's symptom. The pseudoconsole was up (its init sequences arrived) and the shim had not printed after 10 seconds; identical spawns seconds later passed, and that run's whole batch took 19.8 s against a usual 4 to 7. These tests check what a shim receives, not how fast a runner starts processes. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #364. Fixes #368. Fixes #363. Fixes #367.
What was wrong
The recurring explanation for slow CI was "no Rust cache". The job logs of ten
mainruns and three local builds say the cache is a small part of it:bibcode-serverandbibcode-desktopare compiled from scratch every time, and with one codegen unit each compiles on one core. In the bundle step Cargo had started its last dependency after 6 to 7 minutes; the remaining 23 (Linux x64), 42 (Windows x64) and 81 to 107 minutes (macOS arm64) were those two crates and the link.bibcode-serverfive times: 76 of 103 minutes in Cargo builds, about 2 minutes running tests (Windows native desktop rows need about 120 minutes without a Rust cache #368).mainrun). That costs a job about 6 to 12 minutes.dsymutilis not visible. Thebibcode-servercompile peaks at 8.7 to 9.6 GB and the macOS arm64 runner has 7 GB. Memory pressure is the leading explanation and is not measured yet; this pull request adds the measurement.dump_symsCFI error comes from parsing the dSYM, whose unwind section header has no data. Reproduced locally: the stored file had every unwind record of the binary (635,173, 0 lines differ).Evidence and research:
docs/plans/2026-11-14-ci-build-times/research/.What changes
scripts/dump-symbols.ts: whendump_symslogs an error, dump the binary alone; fail if it errors too or theSTACKrecord counts differServer tests - Windows x64/arm64holds the server test steps and the test target check, without-j 2; the native rows no longer build the server for tests--workspace-codegen-units 16: a per-package Cargo override for the two workspace crates. Dependencies keep their fingerprints, and Release does not pass itBundle buildnoticecache-saveonmainonly)docs/operations/ci.md,release.mdand the Windows runbook state the measured causesDecisions to confirm
Verification
vp test run scripts: 952 passed.vp check,vp run typecheck,vp run check:markdown-links,cargo fmt --all --check: pass.The real bundle wrapper started
cargo build --config profile.release.package.bibcode-server.codegen-units=16 --config profile.release.package.bibcode-desktop.codegen-units=16 ...; a rebuild with only that override compiled only the two workspace crates (653 s against 1125 s).The real
dump_symson a local binary and dSYM that logs the error: "the binary's 635173 STACK records are all stored", exit 0.Heartbeat probes: a failing build keeps its exit code, a failing
psand a dead heartbeat do not fail the step.Windows arm64 VM:
cargo test -p bibcode-server --test windows_terminal_shims, 24 passed, including the new timeout test.Reviewed by Codex (plan twice, branch once); findings handled in
docs/plans/2026-11-14-ci-build-times/reviews/and the last commit.Windows arm64 VM: Clippy and
cargo check --all-targetswith warnings denied pass; the new test fails as intended when the collected output is dropped from its message.Acceptance (measured on a manual full run of this branch, 2026-11-14)
Every job passed except Secrets, which failed because a manual run scanned the branch's whole history; the range fix is in this pull request and its pull-request run scans
base..head.Compilinglines, so dependencies were reused under the override.rustcheld 1.6 to 3.6 GB resident for a compile that holds 8.7 GB or more where memory is available. The runner is short of memory for this compile.dsymutilshowed once, at 108 MB. This run also changed the codegen units, so it does not prove what doubled the build on 2026-11-06; memory pressure remains the supported explanation.origin/main..shafor secrets instead of the whole history.What is not fixed: the macOS rows still take about 90 minutes, because one large crate compiles on a 3-core, 7 GB runner. Splitting
bibcode-serveror a larger runner is the remaining lever and is outside this pull request.Profiler coverage: none of the profiler, crash or trace items apply; the change touches CI, build scripts, a test helper and docs.
🤖 Generated with Claude Code