Repository navigation
Conversation
On JRuby these emit warnings when the buffer and PEM strings are
appended to:
lib/httpclient/jruby_ssl_socket.rb:128: warning: literal string will be frozen in the future
lib/httpclient/jruby_ssl_socket.rb:361: warning: literal string will be frozen in the future
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ruby 4.0 warns that the CGI library is removed:
test/helper.rb:9: warning: CGI library is removed from Ruby 4.0. Please use cgi/escape instead for CGI.escape and CGI.unescape features.
The tests only use CGI.escape, which cgi/escape provides.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Avoids the following warning, matching how data_size is already
redefined:
test/test_auth.rb:131: warning: method redefined; discarding old value
vendor/bundle/ruby/4.0.0/bundler/gems/rubyntlm-59ac920c56d8/lib/net/ntlm/security_buffer.rb:33: warning: previous definition of value was here
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Matching a /n regexp against a UTF-8 string warns:
vendor/bundle/ruby/4.0.0/gems/test-unit-3.7.8/lib/test/unit/assertions.rb:602: warning: historical binary regexp match /.../n against UTF-8 string
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
test_post_async_with_default_internal sets Encoding.default_internal on
purpose, so wrap the assignments with the existing silent helper:
test/test_httpclient.rb:771: warning: setting Encoding.default_internal
test/test_httpclient.rb:779: warning: setting Encoding.default_internal
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CI run on master shows the following warnings from httpclient's lib and tests. This pull request fixes them, one commit per warning:
lib/httpclient/jruby_ssl_socket.rb:128and:361:literal string will be frozen in the future(JRuby)test/helper.rb:9:CGI library is removed from Ruby 4.0. Please use cgi/escape instead for CGI.escape and CGI.unescape features.test/test_auth.rb:131:method redefined; discarding old valuetest-unit/assertions.rb:602:historical binary regexp match /.../n against UTF-8 string, caused by a/nregexp intest_post_with_filetest/test_httpclient.rb:771and:779:setting Encoding.default_internalWarnings raised inside dependencies (webrick, rack-ntlm-test-service, rubyntlm) are out of scope.