Repository navigation
chore: remove zalando - #534
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The legacy feature and its associated schema, permissions, generated code, tests, and fixtures are removed consistently.
Review effort: Balanced
Findings: None
What changed in this PR
Removes legacy Zalando Postgres access while retaining the brokered Postgres access flow.
Changes:
- Removes the legacy GraphQL mutation and implementation.
- Removes obsolete Kubernetes permissions and fake-client registration.
- Deletes legacy tests and fixtures.
| File | Description |
|---|---|
internal/persistence/postgres/models.go |
Removes legacy input and payload models. |
internal/persistence/postgres/grant.go |
Deletes Zalando grant implementation. |
internal/persistence/postgres/grant_test.go |
Deletes legacy validation test. |
internal/kubernetes/scheme.go |
Removes legacy resource registration. |
internal/kubernetes/fake/fake.go |
Removes legacy fake-client mapping. |
internal/graph/schema/postgres.graphqls |
Removes the legacy mutation contract. |
internal/graph/postgres.resolvers.go |
Removes the legacy resolver. |
internal/graph/gengql/schema.generated.go |
Updates generated execution code. |
internal/graph/gengql/root_.generated.go |
Updates generated schema metadata. |
internal/graph/gengql/postgres.generated.go |
Removes generated legacy bindings. |
integration_tests/k8s_resources/grant_zalando_postgres_access/dev/someteamname/postgres_foobar.yaml |
Deletes legacy fixture. |
integration_tests/grant_postgres_access.lua |
Deletes legacy integration coverage. |
charts/console-backend-rbac/templates/rbac.yaml |
Removes access to the legacy resource. |
Files not reviewed (2)
- internal/graph/gengql/postgres.generated.go: Generated file
- internal/graph/gengql/schema.generated.go: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
thokra-nav
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed support for this both in cli and console