Repository navigation
Map unrecoverable Postgres branches as degraded - #565
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused mapping change has no identified blocking issues and includes regression coverage, though integration execution remains unverified.
No open issues 🎉
What changed in this PR
Corrects Postgres branch state reporting so unrecoverable recovery failures appear as DEGRADED, even when reconciliation has failed.
Changes:
- Prioritizes terminal recovery failures in state mapping.
- Adds unit coverage and a failed-branch fixture.
- Extends GraphQL coverage for branch states and state facets.
| File | Description |
|---|---|
internal/persistence/postgres/models.go |
Maps unrecoverable recovery failures to DEGRADED. |
internal/persistence/postgres/models_test.go |
Covers terminal and non-terminal failure conditions. |
integration_tests/postgres_branches.lua |
Checks degraded branch state and facet counts. |
integration_tests/k8s_resources/postgres_branches/dev/someteamname/postgres_foobar_failed.yaml |
Adds an unrecoverable branch fixture. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation