Repository navigation
Test the schedule grid components - #12109
Merged
Merged
Conversation
Tests for useScheduleGridProvider (run details visibility, skeleton), ScheduleGrid and its runs (details popover, rating, signup status badges, extended counts), and ScheduleGridApp (day tabs and prefetch, refresh, query variables, errors, legends, rating filter). RunDisplay opened its details on Enter/Space by checking the deprecated keyCode; it uses event.key now. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013mDr1nhgyzST2iPzCzMcCd
Contributor
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Tests for the schedule grid components (
ScheduleGridContext,ScheduleGrid,ScheduleGridEventRun,RunDisplay,RunDetails,SignupStatusBadge, the legends,ConventionDayTabContainer,ScheduleGridApp). No bugs found this time; one small cleanup:RunDisplayopened its details on Enter/Space by checking the deprecatedkeyEvent.keyCode(13/32); it checkskeyEvent.keynow (same behaviour in browsers, and it's whatuser-eventand assistive tech send).Tests (~40):
useScheduleGridProvider: the schedule built from events with their categories, the empty skeleton without a config/convention/events, rating/conflict settings, and run-details visibility (toggling, per-block tracking, closing overlapping runs while leaving non-overlapping ones open).ScheduleGridApp: unknown config, day heading and timezone message, query variables (day range, filters, form items, extended counts), errors, day tabs (links keep the filters, prefetch on hover, refresh), the three legends, rating filter, per-hour counts.The earlier schedule PRs are all merged, so this is independent; it only reuses
scheduleFixtures.Not covered yet
ConventionDayTabContainer's infinite-convention warning,PersonalScheduleFiltersBar's caption logic,StylingUtilsandFakeEventRundirectly (exercised through the grid and legends), and the table view (EventTable).Testing
Full Vitest suite (1312 passed),
tsc --noEmitclean, ESLint no errors.🤖 Generated with Claude Code
https://claude.ai/code/session_013mDr1nhgyzST2iPzCzMcCd