Repository navigation
Test virtual host mapping, sitemaps and timeblock preferences - #12113
Merged
Merged
Conversation
Tests for Intercode::VirtualHostConstraint and FindVirtualHost (host, proxy header and override precedence, assets, debug logging), the sitemap controller (pages, root page, hidden pages, events, dropped events, root site) and EventProposal::TimeblockPreference (time parsing, descriptions, equality with hashes and parameters). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013mDr1nhgyzST2iPzCzMcCd
Contributor
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Tests for three Ruby areas that had no coverage. No production code changes and no bugs found.
Intercode::VirtualHostConstraintandIntercode::FindVirtualHost(how every request is mapped to a convention or the root site): which requests the constraint matches, host /X-Intercode-Convention-Domainheader /with_virtual_host_domainoverride precedence, an earlier layer's convention being left alone, asset requests being skipped, unknown hosts mapping to the root site, and the debug logging. Also thatwith_virtual_host_domainrestores the override when the block raises.SitemapsController: XML format and namespace, pages with theirlastmod, the root page at/, pages hidden from search left out, the events list/schedule/event pages appearing only when there are events, the eventslastmodfollowing the latest event or run, dropped events left out, other conventions' pages not leaking in, and the root site's own pages.EventProposal::TimeblockPreference: time parsing (ISO 8601 strings, offsets, invalid strings raising), attributes and JSON, ordinality descriptions, and equality with other preferences, hashes and controller parameters.Testing
41 tests, 74 assertions; rubocop clean.
🤖 Generated with Claude Code
https://claude.ai/code/session_013mDr1nhgyzST2iPzCzMcCd