Skip to content

Make the "save before it failed" proposal test deterministic #12115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nbudin merged 1 commit into from
Oct 7, 2026
Merged

Make the "save before it failed" proposal test deterministic #12115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion test/javascript/EventProposals/EditEventProposal.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ describe('EditEventProposal', () => {
let deletes: { method: string; path: string }[];
let submitError: Error | undefined;
let updateError: Error | undefined;
let updateDelay: number | undefined;

beforeEach(() => {
user = userEvent.setup();
Expand All @@ -29,6 +30,7 @@ describe('EditEventProposal', () => {
deletes = [];
submitError = undefined;
updateError = undefined;
updateDelay = undefined;
});

const proposalResult = () => buildEventProposalFields();
Expand All @@ -55,6 +57,7 @@ describe('EditEventProposal', () => {
updateEventProposal: { __typename: 'UpdateEventProposalPayload', event_proposal: proposalResult() },
},
},
delay: updateDelay,
maxUsageCount: 50,
},
{
Expand Down Expand Up @@ -145,9 +148,13 @@ describe('EditEventProposal', () => {

it('does not submit, and shows the error, if the save before it failed', async () => {
updateError = new Error('Title is too long');
// (slow enough that the save is certainly still in flight when Submit is clicked, rather than racing it)
updateDelay = 300;
const { findByRole, findByText, queryByText } = await renderPage();
const submitButton = await findByRole('button', { name: 'Submit proposal' });
await waitFor(() => expect(updates).toHaveBeenCalled());

await user.click(await findByRole('button', { name: 'Submit proposal' }));
await user.click(submitButton);

expect(await findByText(/Title is too long/)).toBeTruthy();
expect(submits).not.toHaveBeenCalled();
Expand Down
Loading