Repository navigation
Speed up the autoscaler tests - #12116
Merged
Merged
Conversation
They created hundreds of attendees (5000 for the "never goes above the maximum" test) just to push the scaling target over some threshold. That test now stubs the target instead, and the others use a few dozen attendees, which is enough to take the target above the minimum. The file goes from about a minute to about 4 seconds, and still checks the same things. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013mDr1nhgyzST2iPzCzMcCd
Contributor
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Speeds up
test/services/autoscale_servers_service_test.rb, from about a minute to about 3 seconds. No production code changes.The tests created hundreds of attendees (5000 for "never goes above the maximum") just to push the scaling target over a threshold, and each attendee is a database row plus a user. Now:
scaling_target_for_signup_openingto return a huge target, rather than creating 5000 attendees;All 24 tests still check the same things and pass.
Suggested by @nbudin.
🤖 Generated with Claude Code
https://claude.ai/code/session_013mDr1nhgyzST2iPzCzMcCd