Skip to content

Remove usage of getGradle().getPlugins() - #356

Open
SquidDev wants to merge 2 commits into
neoforged:mainfrom
SquidDev:remove-gradle-plugins
Open

SquidDev wants to merge 2 commits into
neoforged:mainfrom
SquidDev:remove-gradle-plugins

Conversation

@SquidDev

Copy link
Copy Markdown

Attempting to access the global Gradle plugins fails when running with isolated projects (as it counts as mutable state). Instead of checking for a marker plugin on the Gradle object, we now install a marker plugin on every project.

There's some further work to be done here to make MDG compatible with isolated projects (mostly around ModModel's SourceSet references), but I think that requires some discussion first.

Attempting to access the global Gradle plugins fails when running with
isolated projects. Instead of checking for a marker plugin on the Gradle
object, we now install a marker plugin on every project.
@neoforged-pr-publishing

Copy link
Copy Markdown
  • Publish PR to GitHub Packages

@shartte

shartte commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Did they still not add a way to check if the repos are coming from the settings? They were discussing that a while ago

@SquidDev

Copy link
Copy Markdown
Author

Not that I can see. There haven't been any API changes to ArtifactRepositoryContainer or RepositoryHandler for a while now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants