Port upstream CodexBar 0.56.3 [review]

[Finesssee]

Review status

Review only. Do not merge until explicit approval.

Stacked version-only review delta.

This review branch was rebuilt from current main as a clean stack. Its tree was verified byte-for-byte identical to the already-validated local port tip for 0.56.3, so rebuilding the ancestry did not change implementation content.

Stack

• Head: $(System.Collections.Hashtable.head)
• Base: $(System.Collections.Hashtable.base)
• Next version PR, if any, stacks on this branch.

Validation evidence

Porting work was reviewed with local Codex CLI gpt-5.6-luna:max workers and Thermo-style structural checks. The final 0.56.7 stack is clean and passes:

• Rust cargo fmt --check
• git diff --check
• cargo metadata
• Frontend: 57 files / 328 tests
• TypeScript sc --noEmit
• Vite production build
• Locale parity: 825 keys
• Interaction guard: 9/9

Native Rust test/check execution on the local Windows host is blocked before project linking because the host resolves the wrong GNU/Unix link.exe; this is an environment validation limitation, not a proven semantic porting defect.

Merge policy

Please review this PR and the full stack first. Do not merge yet.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: d338da2f-1e09-483b-8761-95a75d47f6f2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[Finesssee]

Thermo-nuclear review: REQUEST CHANGES

The implementation structure is materially better than the prior state: rust/src/providers/grok/mod.rs shrinks from roughly 907 to 473 lines with billing isolated in a provider-local module, and Claude pricing is likewise moved behind a focused module. I found no new production file crossing 1,000 lines and no comparable architecture-boundary blocker.

High - required CUA proof is still missing. This PR changes CodexAccountsMenu, TrayPanel, Codex account display/reset formatting, and the Settings Codex accounts section. Those are explicitly covered by the repo's fresh-Windows-build + CUA requirement. The PR body/comments contain no CUA, screenshots, or equivalent manual visual proof.

Once the required UI/account-switching proof is attached, the code structure itself clears the thermo bar from what I reviewed.