Port upstream CodexBar 0.56.7 [review]

[Finesssee]

Review status

Review only. Do not merge until explicit approval.

Final upstream 0.56.x review delta.

This review branch was rebuilt from current main as a clean stack. Its tree was verified byte-for-byte identical to the already-validated local port tip for 0.56.7, so rebuilding the ancestry did not change implementation content.

Stack

• Head: $(System.Collections.Hashtable.head)
• Base: $(System.Collections.Hashtable.base)
• Next version PR, if any, stacks on this branch.

Validation evidence

Porting work was reviewed with local Codex CLI gpt-5.6-luna:max workers and Thermo-style structural checks. The final 0.56.7 stack is clean and passes:

• Rust cargo fmt --check
• git diff --check
• cargo metadata
• Frontend: 57 files / 328 tests
• TypeScript sc --noEmit
• Vite production build
• Locale parity: 825 keys
• Interaction guard: 9/9

Native Rust test/check execution on the local Windows host is blocked before project linking because the host resolves the wrong GNU/Unix link.exe; this is an environment validation limitation, not a proven semantic porting defect.

Merge policy

Please review this PR and the full stack first. Do not merge yet.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: e13b3348-e255-4293-9b71-772d6122ae72

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Finesssee]

Thermo-nuclear review: REQUEST CHANGES

1. High - core now depends on a CLI implementation detail. rust/src/core/models_dev_pricing.rs calls crate::cli::dashboard::write_atomic. write_atomic is defined in rust/src/cli/dashboard.rs, so a core pricing/cache module now imports the CLI layer just to reuse filesystem mechanics. This is an architecture-boundary inversion even though the helper itself is good. Code-judo: move the atomic-write primitive to a neutral shared filesystem/core utility (or the existing secure/file utility layer if appropriate), then have both the CLI dashboard and models.dev cache depend on that canonical helper.

The rest of this delta is structurally strong: Command Code cache state is split into a provider-local module, ElevenLabs bounds/sanitizes auth bodies, and Kimi/Kiro behavior stays provider-local.

1k/CUA: no new production 1,000-line crossing; this is backend-only, so CUA is not required.