fix(ingester): don't clear a cluster's scope oneof when building a VirtualMachine

[ldrozdz93]

Problem

VirtualMachine(cluster=…, site=…) writes scope_site into the caller's Cluster message. Cluster.scope is a protobuf oneof, so that write silently deletes whatever scope the caller had already set — a SiteGroup, Location or Region.

cluster = Cluster(name="c1", scope_site_group=SiteGroup(name="sg-1"))
VirtualMachine(name="vm-1", cluster=cluster, site=Site(name="site-1"))

cluster.WhichOneof("scope")   # "scope_site" — the SiteGroup is gone

The guard was not cluster.HasField("scope_site"), which is False while a sibling of the oneof holds the scope, so the write went ahead and CopyFrom cleared the sibling.

Fix

ingester.py is generated code. This is the artifact regenerated from netboxlabs/eng-observability-skunkworks#57, which taught the generator to guard a shortcut target belonging to a oneof with WhichOneof(<oneof>) instead of HasField(<field>). Over the current NetBox v4.7.0 generation that is a single line:

-            if cluster is not None and not cluster.HasField("scope_site"):
+            if cluster is not None and not cluster.WhichOneof("scope"):
                 cluster.scope_site.CopyFrom(site)

WhichOneof subsumes the old check, so an unscoped cluster is still filled from the VM's site and an already-scoped one is left alone. The other 19 shortcut writes target fields outside a oneof and are unchanged.

Adds a regression test for the case that was failing.

Closes OBS-3803.

🤖 Generated with Claude Code

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
/opt/hostedtoolcache/Python/3.10.21/x64/lib/python3.10/site-packages/netboxlabs/diode/sdk
chunking.py	33	1	97%	112
client.py	567	42	93%	202–203, 222–224, 227–230, 522, 590, 595, 599, 682–687, 732–734, 764, 768, 772, 794, 815, 817, 891, 922, 930, 992–993, 1002, 1035, 1062, 1067–1068, 1097, 1102–1105
exceptions.py	44	3	93%	69, 82–83
TOTAL	659	46	93%

Tests	Skipped	Failures	Errors	Time
214	0 💤	0 ❌	0 🔥	1.963s ⏱️

[Copilot]

🟢 Approval recommended

The fix is narrowly scoped and includes regression coverage for the affected behavior.

Pull request overview

Fixes VM cluster shortcut handling to preserve existing cluster scope oneof values.

Changes:

• Uses WhichOneof("scope") before populating scope_site.
• Adds regression coverage for existing SiteGroup scope.

File summaries

File	Summary
tests/test_ingester.py	Verifies existing cluster scope is preserved.
netboxlabs/diode/sdk/ingester.py	Applies the oneof-aware guard.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

🎉 This PR is included in version 1.14.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀