release - #112
Merged
Merged
release#112
Conversation
…rtualMachine
VirtualMachine(cluster=..., site=...) filled the cluster's scope_site whenever
HasField("scope_site") was False. Cluster.scope is a oneof, so that guard is
also False when the caller already scoped the cluster to a SiteGroup, Location
or Region, and CopyFrom then silently cleared it.
ingester.py is regenerated output: this is the artifact produced by the
generator fix in netboxlabs/eng-observability-skunkworks#57, whose only change
over the current NetBox v4.7.0 generation is that guard.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ldrozdz93
requested review from
davidlanouette,
jajeffries,
leoparente,
manrodrigues,
mfiedorowicz,
paulstuart and
samiura
as code owners
September 14, 2026 08:02
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||
|
AI Code Review — risk tier: Advisory only. A human owns the merge decision. Summary — This is a release merge (develop → release) whose only substantive change fixes the 🤖 AI Code Review · run · prompts: |
mfiedorowicz
approved these changes
Sep 14, 2026
|
🎉 This PR is included in version 1.14.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.