test: assert version command against __version__ - #20
Merged
Merged
Conversation
The version test hardcoded '0.2.0', so it broke when the package bumped to 0.2.1a0. Compare the output against __version__ instead so the test tracks the actual package version.
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
# Conflicts: # CHANGELOG.md Co-authored-by: jtdub <4454455+jtdub@users.noreply.github.com>
Merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_version_commandhardcodedassert "0.2.0" in result.output, so theversioncommand test failed on thenextbranch once the package bumped to0.2.1a0— the command itself prints the version correctly.Changes
tests/test_cli.py: import__version__from the package and assert the command output contains it, instead of a hardcoded string.CHANGELOG.md: entry under Unreleased.Validation
tests/test_cli.py::test_version_commandpasses.