Repository navigation
Jglweb 1832 cke5 plugin - #126
amalija-ramljak wants to merge 8 commits into
Conversation
amalija-ramljak
commented
Oct 20, 2026
- plugin is a regular function instead of arrow - so creating doesn't fail
- fixed fieldid to use cke5 uid instead of trying to count fields on the edit page
- fixed config merge to be a deep merge instead of shallow
- allow storage format for cke5 to be configurable - defaults match what current projects using this plugin have in the db, but change is needed for ibexa and its custom tags handling
- skip fetch requests for empty fields
|
Tested this on Sylius (sklepex). The CKEditor 5 plugin breaks there when you insert a new media element. Clicking the "Netgen Remote Media" toolbar button throws, and nothing is inserted: On the current Cause: The same error also happens on upcast for a stored element without Suggested fix: don't depend on The other changes look fine for Sylius: the deep merge keeps our |
|
Okay so, sklepex/Sylius would otherwise need to expose uid the way it exposes other things from their prebuilt cke5 that are needed for the plugin |
|
@amalija-ramljak Two more issues: Existing content stores data-ngrmcke5-alignment="undefined", because the old plugin never read that attribute back. fromView now reads it as the string "undefined", so opening and saving an unchanged page adds style="text-align:undefined;" to every embedded resource. Minor: upcast.js now spreads an error response from the selected-image endpoint into selectedImage. |
|
@RandyCupic both should be fixed now, can you re-test please? |