Repository navigation
Fix Doctrine mapping namespaces and declare missing dependencies - #127
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of two fixes from #125, both found while installing the bundle into a fresh Symfony app.
http://doctrine-project.org/schemas/orm/doctrine-mappingandhttp://www.w3.org/2001/XMLSchema-instancenamespaces. Withhttps://, Doctrine's XML validation rejects the mappings. That validation is on whenvalidate_xml_mapping: trueis set, as in the current DoctrineBundle recipe. Both mappings now validate against the Doctrine XSD.symfony/serializerandsymfony/translationare now required. The bundle enables the serializer in its prepended framework config, and its controllers depend on thetranslatorservice, so a minimal app failed to boot without them.Existing projects already have both components installed and do not enable XML validation, so this changes nothing for them.
Tests (593) pass on Symfony 5.4 and 6.4. PHPStan and CS are clean.