Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,10 @@ jobs:
for node in $node_versions; do
OS_NODE+=("ubuntu-latest:$node")
done
if [[ "$HEAD_REF" == release-please--* ]]; then
# XXX(serhalp): also run the macOS + Windows matrix on this branch so we can verify the new keychain code
# paths before merge.
# Revert before merging.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so you don't forget.

if [[ "$HEAD_REF" == release-please--* || "$HEAD_REF" == "serhalp/feat/native-token-keychain-storage" ]]; then
for os in $extra_oses; do
OS_NODE+=("$os:$primary")
done
Expand Down
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,8 @@ Every `track()` event includes these properties, which callers can't override:
- `ci_is_pr`: whether the CI run is for a pull request, on platforms that expose it

Properties with no value are omitted. The `cli:command` event sent after each command also includes `command`, `opts`
(with sensitive values masked), `args`, `frameworks`, `buildSystem`, `packageManager`, and `monorepo`.
(with sensitive values masked), `args`, `frameworks`, `buildSystem`, `packageManager`, `monorepo`, and
`authTokenSource` (`flag`, `env`, `config`, `keychain`, or `not found`).

The test suites set `NETLIFY_TELEMETRY_DISABLED` in their Vitest config, so tests never send real telemetry. Tests that
spawn the CLI with `extendEnv: false` must pass it explicitly.
Expand Down
3 changes: 2 additions & 1 deletion docs/commands/login.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ description: Login to your Netlify account

<!-- AUTO-GENERATED-CONTENT:START (GENERATE_COMMANDS_DOCS) -->
Login to your Netlify account
Opens a web browser to acquire an OAuth token.
Opens a web browser to acquire an OAuth token, which is stored in your OS keychain when available.
To store it in a plaintext config file instead, set NETLIFY_USE_LEGACY_AUTH_STORAGE=1. This is not recommended.

**Usage**

Expand Down
2 changes: 1 addition & 1 deletion docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,6 @@ A program that runs `netlify login` on a user’s behalf can set `NETLIFY_LOGIN_

## Telemetry

The CLI sends usage telemetry and error reports to `cli.netlify.com`. Usage telemetry covers which commands run, their flags with sensitive values masked, the CLI and Node.js versions, the detected framework and package manager, the AI agent running the CLI, and the CI platform.
The CLI sends usage telemetry and error reports to `cli.netlify.com`. Usage telemetry covers which commands run, their flags with sensitive values masked, the CLI and Node.js versions, the detected framework and package manager, the AI agent running the CLI, the CI platform, and where the auth token is stored (never the token itself).

To disable telemetry, run `netlify --telemetry-disable`, or set `NETLIFY_TELEMETRY_DISABLED=1` or `DO_NOT_TRACK=1`. The environment variables also disable error reporting, and are the most reliable option in CI, where the setting saved by `--telemetry-disable` may not persist between runs.
2 changes: 1 addition & 1 deletion eslint-suppressions.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"count": 7
},
"@typescript-eslint/no-unsafe-assignment": {
"count": 14
"count": 13
},
"@typescript-eslint/no-unsafe-call": {
"count": 2
Expand Down
247 changes: 241 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"@netlify/build-info": "^11.3.1",
"@netlify/config": "^25.5.1",
"@netlify/dev": "^5.1.12",
"@netlify/dev-utils": "^6.0.4",
"@netlify/dev-utils": "https://pkg.pr.new/@netlify/dev-utils@2b6145e",

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Will replace before merging

"@netlify/edge-bundler": "^16.2.0",
"@netlify/edge-functions": "^4.0.3",
"@netlify/edge-functions-bootstrap": "^3.2.0",
Expand Down Expand Up @@ -212,6 +212,9 @@
"verdaccio": "^6.3.2",
"vitest": "^5.0.0"
},
"overrides": {
"@netlify/dev-utils": "$@netlify/dev-utils"
},
Comment on lines +215 to +217

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(same here)

"engines": {
"node": ">=22.13.0"
},
Expand Down
Loading
Loading