Repository navigation
Store CLI credentials in Linux Secret Service - #360
Merged
Merged
Conversation
ctfbruce
marked this pull request as ready for review
October 2, 2026 12:16
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI login can now save its local Debuglet credential in Linux Secret Service. The default auto mode selects it when secret-tool and a desktop D-Bus session are available; headless machines retain the explicit owner-only file fallback. A locked or failed system store is reported rather than silently downgraded. Stored metadata contains an opaque reference, and credentials remain bound to the dispatcher and profile. Logout revokes the server credential and removes its local entry; interrupted or failed saves trigger revocation.
The authentication upgrade guide now covers backups, an offline rehearsal, cutover, rollback and existing recovery codes. A migration regression proves historical accounts retain their separate ownership without acquiring invented credentials or provider identities. UUID authentication was already rejected and no new account-claim mechanism is added.
References #225 and #226. The existing provider-neutral browser/headless protocol was merged in #357. Historical accounts with no verifiable credential still need an independently verified recovery process, and real CILogon/hosted cutover acceptance remains external.
Validation: focused Linux connection/CLI tests pass under the race detector, the CLI builds, and the schema-5-to-current ownership migration test passes. A real Secret Service and native TLS dispatcher rehearsal passed system-store selection without plaintext metadata, persistence after keyring restart, headless device approval, old-item cleanup, immediate server revocation on logout, and explicit 0600 file fallback. It used an isolated D-Bus/XDG session and an account-key fixture for browser approval; no hosted provider was called. All 16 checks pass in CI run 37004262952. No deployment is included.